Date: Fri, 17 Jan 2014 13:45:21 +0100 From: Pietro Cerutti <gahr@FreeBSD.org> To: Mathieu Arnold <mat@FreeBSD.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r340026 - head/net-im/libpurple Message-ID: <20140117124521.GF4006@gahrfit.gahr.ch> In-Reply-To: <884B7C619AAEEC285129466D@atuin.in.mat.cc> References: <201401171033.s0HAX99I020937@svn.freebsd.org> <884B7C619AAEEC285129466D@atuin.in.mat.cc>
next in thread | previous in thread | raw e-mail | index | archive | help
--a+b56+3nqLzpiR9O
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On 2014-Jan-17, 11:47, Mathieu Arnold wrote:
> +--On 17 janvier 2014 10:33:09 +0000 Pietro Cerutti <gahr@FreeBSD.org>
> wrote:
> | .if ${PORT_OPTIONS:MTCLTK}
> | -USE_TK=3D yes
> | -CFLAGS+=3D -I${LOCALBASE}/include/tk${TK_VER}
> | -I${LOCALBASE}/include/tcl${TCL_VER} -CONFIGURE_ARGS+=3D
> | --with-tclconfig=3D${LOCALBASE}/lib/tcl${TCL_VER} \ -
> | --with-tkconfig=3D${LOCALBASE}/lib/tk${TK_VER}
> | +USES+=3D tk
> | +CFLAGS+=3D -I${TK_INCLUDEDIR} -I${TCL_INCLUDEDIR}
> | +CONFIGURE_ARGS+=3D --with-tclconfig=3D${TCL_LIBDIR} \
> | + --with-tkconfig=3D${TK_LIBDIR}
>=20
> Which is way better written as :
>=20
> TCLTK_USES=3D tk
> TCLTK_CFLAGS=3D -I${TK_INCLUDEDIR} -I${TCL_INCLUDEDIR}
> TCLTK_CONFIGURE_ON=3D --with-tclconfig=3D${TCL_LIBDIR} \
> --with-tkconfig=3D${TK_LIBDIR}
Nice framework. But given that I have to enclose stuff in
=2Eif ${PORT_OPTIONS:MTCLTK}=20
anyway because of PLIST_SUB and CONFIGURE_ARGS, what's the benefit?
--=20
Pietro Cerutti
The FreeBSD Project
gahr@FreeBSD.org
PGP Public Key:
http://gahr.ch/pgp
--a+b56+3nqLzpiR9O
Content-Type: application/pgp-signature
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (FreeBSD)
iQJ8BAEBCgBmBQJS2SXYXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w
ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXREQTZERTEwNkE1Qjg1NEI4NUREODZENDlB
REQwRDM4RUExOTIwODlFAAoJEK3Q046hkgiekfkP/2zw9MVZK5lC4WJP7gRDk4hS
iomcKG6drptimpeLDRi29pcI2zNX83sEd1oC7zwmQZzLDJRVEECONaP18q8+xTwE
hyvTQVg8ak/1m0hw6U4lzkIuLEys/P4ohg8tNYe8FpIb8meoi+fQQcXGE3kdsYqO
ULSTRRAt2obrHf6MYbZF+QmwBBvZ+PIgQjM5EVn7h5u5D3KIfFfCWgUfvbwvMRLW
UeiDZK/j+e0gT7digU5nSKHu65nQ5dV3oASv9u1D4VhxVrNUmG2WB4/N7O4sM6bb
yECZ1GU0qnX0UiXy4GhAIiKLgkRB5sRHzjiqW9QFJa5xDFYeeBmQERotSQWUfPHF
qPyfJc83VhvodHevmbx+exCf6DlqVKmAy6DDmwf++WZbpADpW66D6lZyELfK93v7
nN+nNQDG8gMccDWhUyD6kwzzwARa6R5Elxx/H1DsVnBxdGthC7Yhmal5dvK/FO5U
a+KzmiP0uXkMw6/lyPQTATGqBzdmFOgsYKvN/6MBeadRrACCdR5LZopK4jAwilYT
yiYPf3B0/z82P3u/3ZDa8b+iEqUmVPaCeHRlUAECJyOxUhCow8nPo5CqBNd1k6iY
2Evtz4rppz8heSHSECeFrpDz+Fj2kscDCA+13285jFDhXgbn7sFIk2EphvaUdRXI
0+XzUv4yPjhzjQUmA4FT
=zzVs
-----END PGP SIGNATURE-----
--a+b56+3nqLzpiR9O--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20140117124521.GF4006>