From owner-freebsd-stable Mon Mar 12 6:56:28 2001 Delivered-To: freebsd-stable@freebsd.org Received: from probity.mcc.ac.uk (probity.mcc.ac.uk [130.88.200.94]) by hub.freebsd.org (Postfix) with ESMTP id 3E1B637B71B for ; Mon, 12 Mar 2001 06:56:24 -0800 (PST) (envelope-from jcm@freebsd-uk.eu.org) Received: from dogma.freebsd-uk.eu.org ([130.88.200.97] ident=root) by probity.mcc.ac.uk with esmtp (Exim 2.05 #4) id 14cTkF-000MQf-00; Mon, 12 Mar 2001 14:56:23 +0000 Received: (from jcm@localhost) by dogma.freebsd-uk.eu.org (8.11.1/8.11.1) id f2CEuNl88132; Mon, 12 Mar 2001 14:56:23 GMT (envelope-from jcm) Date: Mon, 12 Mar 2001 14:56:22 +0000 From: j mckitrick To: Ian Dowse Cc: Alfred Perlstein , freebsd-stable@freebsd.org Subject: Re: suspend/restore with ppp connections Message-ID: <20010312145622.A87895@dogma.freebsd-uk.eu.org> References: <20010312135826.F86948@dogma.freebsd-uk.eu.org> <200103121440.aa97105@salmon.maths.tcd.ie> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Mailer: Mutt 1.0.1i In-Reply-To: <200103121440.aa97105@salmon.maths.tcd.ie>; from iedowse@maths.tcd.ie on Mon, Mar 12, 2001 at 02:40:58PM +0000 Sender: owner-freebsd-stable@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG | The problem is that the card has been reattached, so com->gone is | 0. However com->tp is NULL because the driver has not seen an open() | since attachment. It would probably be possible to add a few tests | for com->tp != NULL in a few places, but sio.c has bigger problems | in this area. It seems that a struct tty will be leaked for every | insert/removal too. There is also a missing call to the line | discipline's l_close function in the forced detach case. Now this is the kind of thing I would be interested in helping fix. But if you say sio has bigger problems, I might be in over my head. What would happen if I just added those tests for NULL? jm -- ------------------------------------------------------------------- Jonathon McKitrick -- jcm@freebsd-uk.eu.org To Microsoft: "Your tyranny I was part of, is now cracking on every side. Now your own life is in danger. Your Empire is on fire." Front 242 ------------------------------------------------------------------- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-stable" in the body of the message