Date: Mon, 28 Nov 2005 03:30:18 -0500 From: Kris Kennaway <kris@obsecurity.org> To: Edwin Groothuis <edwin@mavetju.org> Cc: cvs-ports@FreeBSD.org, ports-committers@FreeBSD.org, cvs-all@FreeBSD.org, Kris Kennaway <kris@obsecurity.org> Subject: Re: cvs commit: ports/misc Makefile ports/misc/instant-tinderbox Makefile pkg-descr Message-ID: <20051128083018.GA14660@xor.obsecurity.org> In-Reply-To: <20051128082410.GO1265@k7.mavetju> References: <200511280557.jAS5va2I051976@repoman.freebsd.org> <20051128061137.GA11774@xor.obsecurity.org> <20051128075604.GM1239@k7.mavetju> <20051128080208.GA14243@xor.obsecurity.org> <20051128082410.GO1265@k7.mavetju>
next in thread | previous in thread | raw e-mail | index | archive | help
--OgqxwSJOaUobr8KG Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Nov 28, 2005 at 07:24:10PM +1100, Edwin Groothuis wrote: > On Mon, Nov 28, 2005 at 03:02:09AM -0500, Kris Kennaway wrote: > > On Mon, Nov 28, 2005 at 06:56:04PM +1100, Edwin Groothuis wrote: > > > On Mon, Nov 28, 2005 at 01:11:37AM -0500, Kris Kennaway wrote: > > > > I think this port is a bad idea. It'll take a fairly long time to > > > > build on pointyhat from all the pkg_adds (and it will be right at t= he > > > > end of the package builds since it depends on everything else, so t= he > > > > whole build will end up waiting for it), and it's not useful for > > > > anyone apart from users of marcus' tinderbox scripts. Therefore it > > > > should be reimplemented there instead. > > >=20 > > > If I add a .ifdef to it which prevents it from being attempted to > > > build on non-tinderbox systems, is that a good solution? Or does > > > the packaging system ignore IGNOREs? > >=20 > > No, it respects IGNORE..but I still don't see why it should be a port > > instead of a small shell script included with the tinderbox. >=20 > Because a port understands that if I do USE_OPENLDAP, it will come > up with the version of net/openldap which is currently defined > in the ports framework, and if I do USE_PGSQL, it will come up with > the version of databases/pgsql-xx-server which is currently defined > in the ports framework. >=20 > With an external script I have to somehow find out what the current > versions for the USE_OPENLDAP and USE_PGSQL variables are. And > besides invoken the powers of Make I have no idea how to do it > properly. Those dependencies mostly come in via existing large ports like kde. The list of ports to build to achieve the same effect is very small, and putting the list of ports to buil in a shell script (or config file) has the advantage that tinderbox users can easily customize it to build the ports they care about. Kris --OgqxwSJOaUobr8KG Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2 (FreeBSD) iD8DBQFDisAaWry0BWjoQKURAgKrAKCNxfO+YLrSTje/Ibt6OQgfNaLgEgCeMa7q fTw0ah3cjBUsqsQJH7Ror1I= =P311 -----END PGP SIGNATURE----- --OgqxwSJOaUobr8KG--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20051128083018.GA14660>