Date: Sun, 20 Apr 2014 14:48:33 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: Joe Marcus Clarke <marcus@FreeBSD.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r351606 - head/net/netatalk Message-ID: <20140420144833.GB89106@FreeBSD.org> In-Reply-To: <201404191907.s3JJ7gAR096735@svn.freebsd.org> References: <201404191907.s3JJ7gAR096735@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Apr 19, 2014 at 07:07:42PM +0000, Joe Marcus Clarke wrote: > New Revision: 351606 > URL: http://svnweb.freebsd.org/changeset/ports/351606 > QAT: https://qat.redports.org/buildarchive/r351606/ > > Log: > * Convert to STAGE > * Only enable AppleTalk support on versions of FreeBSD that support it [1] > > [...] > +APPLETALK_DESC= AppleTalk protocol support (where supported) This change is bogus. You could've simply make this option conditional. For example, cf. games/doomlegacy: .if exists(/usr/include/netipx/ipx.h) OPTIONS_DEFINE+= IPX IPX_DESC= IPX protocol support .endif > -.if ${PORT_OPTIONS:MAPPLETALK} > +.if ${OSVERSION} < 1100013 && ${PORT_OPTIONS:MAPPLETALK} Is it possible to use exists() here instead of OSVERSION? We're generally trying to get rid of OSVERSION checks... ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20140420144833.GB89106>