From owner-svn-src-all@freebsd.org Sat Jan 2 22:46:44 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 64BE2A5EDA6 for ; Sat, 2 Jan 2016 22:46:44 +0000 (UTC) (envelope-from ian@freebsd.org) Received: from outbound1b.ore.mailhop.org (outbound1b.ore.mailhop.org [54.200.247.200]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 491FE1B1D for ; Sat, 2 Jan 2016 22:46:43 +0000 (UTC) (envelope-from ian@freebsd.org) Received: from ilsoft.org (unknown [73.34.117.227]) by outbound1.ore.mailhop.org (Halon Mail Gateway) with ESMTPSA; Sat, 2 Jan 2016 22:47:09 +0000 (UTC) Received: from rev (rev [172.22.42.240]) by ilsoft.org (8.14.9/8.14.9) with ESMTP id u02MkfsQ026767; Sat, 2 Jan 2016 15:46:41 -0700 (MST) (envelope-from ian@freebsd.org) Message-ID: <1451774801.1369.112.camel@freebsd.org> Subject: Re: svn commit: r293053 - head/sys/boot/uboot/lib From: Ian Lepore To: "Bjoern A. Zeeb" Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Date: Sat, 02 Jan 2016 15:46:41 -0700 In-Reply-To: <90CAFE3D-DB95-4790-8FBD-9C40E6BF1075@lists.zabbadoz.net> References: <201601021816.u02IGOXQ060620@repo.freebsd.org> <90CAFE3D-DB95-4790-8FBD-9C40E6BF1075@lists.zabbadoz.net> Content-Type: text/plain; charset="us-ascii" X-Mailer: Evolution 3.16.5 FreeBSD GNOME Team Port Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 02 Jan 2016 22:46:44 -0000 On Sat, 2016-01-02 at 22:20 +0000, Bjoern A. Zeeb wrote: > > On 02 Jan 2016, at 18:16 , Ian Lepore wrote: > > > > Author: ian > > Date: Sat Jan 2 18:16:24 2016 > > New Revision: 293053 > > URL: https://svnweb.freebsd.org/changeset/base/293053 > > > > Log: > > Use 64-bit math when finding a block of ram to hold the kernel. > > This fixes > > a problem on 32-bit systems which have ram occupying the end of > > the physical > > address space -- for example, a block of ram at 0x80000000 with a > > size of > > 0x80000000 was overflowing 32 bit math and ending up with a > > calculated size > > of zero. > > > > This is a fix for one of the two problems mentioned in the PR. > > Something > > similar will need to be done on the kernel side before the PR is > > closed. > > > > PR: 201614 > > > > Modified: > > head/sys/boot/uboot/lib/copy.c > > > This seems to have broken powerpc/powerpc64 worlds: > > ===> sys/boot/uboot/lib (all) > cc1: warnings being treated as errors > /scratch/tmp/bz/head.svn/sys/boot/uboot/lib/copy.c: In function > 'uboot_loadaddr': > /scratch/tmp/bz/head.svn/sys/boot/uboot/lib/copy.c:103: warning: cast > from pointer to integer of different size > --- copy.o --- > *** [copy.o] Error code 1 > Grrrr. Casting from a pointer to an integer of a different size is exactly what I want to do, and I thought explicitly casting was a rather elegant way of expressing that. -- Ian