From owner-svn-ports-head@freebsd.org Fri Apr 27 03:59:24 2018 Return-Path: Delivered-To: svn-ports-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 64505FBFC5C for ; Fri, 27 Apr 2018 03:59:24 +0000 (UTC) (envelope-from bounce+d9b290.b1b642-svn-ports-head=freebsd.org@home.dimapanov.com) Received: from mail2.static.mailgun.info (mail2.static.mailgun.info [104.130.122.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 01C9C818CE for ; Fri, 27 Apr 2018 03:59:23 +0000 (UTC) (envelope-from bounce+d9b290.b1b642-svn-ports-head=freebsd.org@home.dimapanov.com) DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=home.dimapanov.com; q=dns/txt; s=smtp; t=1524801563; h=Content-Transfer-Encoding: Content-Type: In-Reply-To: MIME-Version: Date: Message-ID: From: References: Cc: To: Subject: Reply-To: Sender; bh=/olVuzF9oshNLx07XQXcT0pYpV+TjgIX3qJTjR09n00=; b=C3J5MJaMH+qBq6VkPdSaTNWgLb7q8po4ozBT2WFbCPoT8QBjGyQGkHa9Fbrp5JTVdfwxWWmr VL/p8dLs6aletpxDZHToZT4oXRJAeU5ONZ7sxtx7/vUQ7f1XTweFt9in/UZX0/5DXhwav1qq k95vNIAb3X/kDljm1nTGf+eMBc8= X-Mailgun-Sending-Ip: 104.130.122.2 X-Mailgun-Sid: WyIxMjQ5NSIsICJzdm4tcG9ydHMtaGVhZEBmcmVlYnNkLm9yZyIsICJiMWI2NDIiXQ== Sender: fuffy=freebsd.org@home.dimapanov.com Received: from iMac-Fluffy.local (Unknown [138.99.210.223]) by mxa.mailgun.org with ESMTP id 5ae2a01a.7f72db577f48-smtp-out-n02; Fri, 27 Apr 2018 03:59:22 -0000 (UTC) Reply-To: fluffy@FreeBSD.org Subject: Re: svn commit: r468319 - in head/mail: opensmtpd opensmtpd-devel opensmtpd-devel/files opensmtpd/files To: Adam Weinberger Cc: fluffy@FreeBSD.org, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org References: <201804260053.w3Q0r1ls098687@repo.freebsd.org> <03CA4FC0-D636-4A40-A820-AF746EF35499@adamw.org> <2315c626-9bc9-35bd-0f61-3f8e77f54237@FreeBSD.org> <9D94AB40-9623-45BA-8F5C-95B548DF0D40@adamw.org> From: Dima Panov Message-ID: Date: Fri, 27 Apr 2018 13:59:16 +1000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:52.0) Gecko/20100101 PostboxApp/6.0.5 MIME-Version: 1.0 In-Reply-To: <9D94AB40-9623-45BA-8F5C-95B548DF0D40@adamw.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: ru Content-Transfer-Encoding: 8bit X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Apr 2018 03:59:24 -0000 Adam Weinberger wrote: >> On 26 Apr, 2018, at 20:30, Dima Panov wrote: >> >> >> >> Adam Weinberger wrote: >>>> On 25 Apr, 2018, at 18:53, Dima Panov wrote: >>>> >>>> Author: fluffy >>>> Date: Thu Apr 26 00:53:01 2018 >>>> New Revision: 468319 >>>> URL: https://svnweb.freebsd.org/changeset/ports/468319 >>>> >>>> Log: >>>> - Pet MDA part, add brackets around Return-Path as per RFC5322 >>>> §3.6.6. >>>> >>>> Missing brackets lead to a panic when a malformed address line >>>> is fed to dovecot-lda >>>> >>>> Submitted by: gahr >>>> Reported by: brnrd via dovecot ML >>>> Obtained from: >>>> https://github.com/OpenSMTPD/OpenSMTPD/pull/847/commits/725ba4fa2ddf23bbcd1ff9ec92e86bbfaa6825c8 >>>> >>> Thanks for doing this, Dima. This should probably be merged to >>> quarterly, no? >> >> Only Dovecot23+ affected this "bug" yet, so while 2018Q2 lives without >> it, MFH is not critically needed. >> But yes, I'm also thinking about MFH, just to be sured in. > > IIRC rspamd had to work around this behavior a while back. It’s > certainly a bug fix, but only dovecot seems to have broken spectacularly > here recently. > > I don’t feel strongly about it one way or the other. I defer to your > judgement. > MFH done as r468396. Certainly I prefer to be sured in case where another lda shouldn't face a RFC workaround. -- Dima Panov (fluffy@FreeBSD.org) (X11, KDE, Office)@FreeBSD team Facebook: http://www.facebook.com/fluffy.khv twitter: fluffy_khv | skype: dima.panov | telegram: @dima_panov IRC: fluffy@EFNet, fluffykhv@FreeNode