From owner-freebsd-hackers Thu May 25 7:52:58 2000 Delivered-To: freebsd-hackers@freebsd.org Received: from mail.surf1.de (mail.surf1.de [194.25.165.21]) by hub.freebsd.org (Postfix) with ESMTP id 7473437C358 for ; Thu, 25 May 2000 07:52:47 -0700 (PDT) (envelope-from alex@cichlids.com) Received: from cichlids.com (p3E9C1172.dip0.t-ipconnect.de [62.156.17.114]) by mail.surf1.de (8.9.3/8.9.3) with ESMTP id QAA15262; Thu, 25 May 2000 16:52:19 +0200 Received: from cichlids.cichlids.com (cichlids.cichlids.com [192.168.0.10]) by cichlids.com (Postfix) with ESMTP id E9194AC2C; Thu, 25 May 2000 16:52:44 +0200 (CEST) Received: (from alex@localhost) by cichlids.cichlids.com (8.9.3/8.9.3) id QAA84682; Thu, 25 May 2000 16:52:43 +0200 (CEST) (envelope-from alex) Date: Thu, 25 May 2000 16:52:43 +0200 From: Alexander Langer To: Johan Karlsson Cc: hackers@FreeBSD.ORG Subject: Re: review request: truncate(1) Message-ID: <20000525165243.A84651@cichlids.cichlids.com> References: <20000525141817.A17484@cichlids.cichlids.com> <200005251446.QAA12958@numeri.campus.luth.se> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Mailer: Mutt 1.0.1i In-Reply-To: <200005251446.QAA12958@numeri.campus.luth.se>; from k@numeri.campus.luth.se on Thu, May 25, 2000 at 04:46:51PM +0200 X-PGP-Fingerprint: 44 28 CA 4C 46 5B D3 A8 A8 E3 BA F3 4E 60 7D 7F X-Verwirrung: Dieser Header dient der allgemeinen Verwirrung. Sender: owner-freebsd-hackers@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG Thus spake Johan Karlsson (k@numeri.campus.luth.se): > Please sort the options in getopt and in the switch-statement. > see style(9) for more style info. > Please also use -Wall when compiling to catch all warnings True - forget about that. What about the other things, I mean non-stylistic but functional/technical stuff? Alex -- I need a new ~/.sig. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-hackers" in the body of the message