From owner-svn-src-all@freebsd.org Sun Dec 24 09:11:06 2017 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 41C7CEA7C25 for ; Sun, 24 Dec 2017 09:11:06 +0000 (UTC) (envelope-from 0100016087ca1f30-a88d99db-d557-441e-abe8-6a0bd7c5d6e6-000000@amazonses.com) Received: from a8-56.smtp-out.amazonses.com (a8-56.smtp-out.amazonses.com [54.240.8.56]) (using TLSv1 with cipher ECDHE-RSA-AES128-SHA (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 08AB570283 for ; Sun, 24 Dec 2017 09:11:05 +0000 (UTC) (envelope-from 0100016087ca1f30-a88d99db-d557-441e-abe8-6a0bd7c5d6e6-000000@amazonses.com) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=ae7m2yrxjw65l2cqdpjxuucyrvy564tn; d=tarsnap.com; t=1514106659; h=Subject:To:References:From:Message-ID:Date:MIME-Version:In-Reply-To:Content-Type:Content-Transfer-Encoding; bh=jtk5PAnadJ/gvAecymUZ8A4CNnpHTHGuMCkmarYIf6A=; b=hR3uctxgn5W7fvk9n/diwLOR75S6/mCEgRelQu9Q+KiVn95oxsF88XlirZpwACvM 3+0J/FjJCsL73P70HjcGtqKg+rOPyCu+ljGe/O78czItYLq28Qrf7WDBG2nlW0uhoIu UxCEx7W1S3LgrTRJwEVFPHZUGxx3JpRcW2o3j/JI= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/simple; s=224i4yxa5dv7c2xz3womw6peuasteono; d=amazonses.com; t=1514106659; h=Subject:To:References:From:Message-ID:Date:MIME-Version:In-Reply-To:Content-Type:Content-Transfer-Encoding:Feedback-ID; bh=jtk5PAnadJ/gvAecymUZ8A4CNnpHTHGuMCkmarYIf6A=; b=ij0o8SV9R6fDxzlrrrK81d7vDeAnG/A32mA1XggMRJPLWXrfwcygFG5S9HNCy9Tk qlgS9y7T5M0yAF0vGxwSLw1d1mXStcn6tjafTxp+vUBNsof/798Yoe4Hm11OWZbi1FE 3Eot1crC2D4C2drb1Amd1Ug3BlONCWTtQ8RL3oOU= Subject: Re: svn commit: r327120 - in head/sys: isa x86/isa To: Warner Losh , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201712232257.vBNMvEHk023093@repo.freebsd.org> From: Colin Percival Message-ID: <0100016087ca1f30-a88d99db-d557-441e-abe8-6a0bd7c5d6e6-000000@email.amazonses.com> Date: Sun, 24 Dec 2017 09:10:58 +0000 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <201712232257.vBNMvEHk023093@repo.freebsd.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SES-Outgoing: 2017.12.24-54.240.8.56 Feedback-ID: 1.us-east-1.Lv9FVjaNvvR5llaqfLoOVbo2VxOELl7cjN0AOyXnPlk=:AmazonSES X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 24 Dec 2017 09:11:06 -0000 On 12/23/17 14:57, Warner Losh wrote: > - device_probe_and_attach(child); > + err = device_probe_and_attach(child); > + if (err == 0 && idev->id_vendorid == 0 && > + strcmp(kern_ident, "GENERIC") == 0) > + device_printf(child, > + "non-PNP ISA device will be removed from GENERIC in FreeBSD 12."); Maybe worth making this strncmp(kern_ident, "GENERIC", 7) so that it will catch GENERIC-NODEBUG as well? -- Colin Percival Security Officer Emeritus, FreeBSD | The power to serve Founder, Tarsnap | www.tarsnap.com | Online backups for the truly paranoid