From nobody Thu Jul 6 08:34:57 2023 X-Original-To: dev-commits-ports-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4QxVGL57xVz4mHQ3; Thu, 6 Jul 2023 08:35:22 +0000 (UTC) (envelope-from rakuco@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4QxVGL4YvPz3JYF; Thu, 6 Jul 2023 08:35:22 +0000 (UTC) (envelope-from rakuco@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1688632522; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+SXFVYy6pWNlYvICOmiKtdCS+otNZ5vLQ3YWi5EXDTo=; b=S1BR2mHqMLZjtNVwT6ufiUqG1nGDSueXmka1aMnEoMqyEjtlX+5FOji1BE9kX6Q7we09eX QxfPqTxewYFnGj7jrPhMGMuNvuNt2pxNHwKlwD4WedxFsCLZM0/MAV21l8VYZxyhjd8fYb OxaGdX8uoKzSdkWtJEUkHI/jjwpXJhqoevkpcovI8Sw/K7WtffCT3ULbscfIfcCaNopcUu hVTR/dXD26qGHwUAillutmEUUMb5NMO6elMZSaQaA0nk1ZfUVfKTUHjvWKtzHMpkYHGChI xvc1r+aV6P4QEMAXT8b5lKBTLfhetgNgEWht8IKN0140ZqDvphc8L+VllLVgUw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1688632522; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+SXFVYy6pWNlYvICOmiKtdCS+otNZ5vLQ3YWi5EXDTo=; b=BofIEev0xMq3QDLbgHdug/VZjOjk7No+F/kXZBAW8Sfbt60o/FwQZPBrUg59xetV9Tvg+Q 5HS9uP3zIGCN9NzVV8lvMT0z9EAN0U7lLUHElhJXefOabPc84Dn6o0xkEuxAY6Comg6Vl2 FHRZnTP5joec+niSYUn56KHQ999y/nPsV62wYs0mpj1fn8cVI7YZkARN/nzu8pDhcMYGqt 2JFSmm5xxKUtbegXxAUsCNuVF0b4m0H/+KWmvGTXxNJMTl/LPoTD6um8seFeLvjM6djp60 ofJedcGJ5gC1OsOL8W+I+vbKHEHbaPu0N5ST03NdJDcZafX2mYulfMLFIeGHNw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1688632522; a=rsa-sha256; cv=none; b=HSUWsMLbHVuXpB4/0Fh+gO7pv4j9wMlxQo5yVt8BTtLg7olG2XAtPP3KEUriL2vjwsXroK sMiZ0rqk2JQ4PmdWq3GZZgdk+33CLtwcOykdjr7PRGJIpEBBziobO0zO8IDLB7bDmFnh3j XFiIfLOCHWlhmNFZkVqa3l6YWYPwla2BC4Zs7dFEVLsYODhrpOaqWWL7qQbMPCzzad064M 46ymRLWwI4mYB3Szo/icYuch26e9DOIesWSndwZL0jJj6EYbV0Xy8OzvV5PE2eUPkFXGPA tTBsWjtaINvrrSM5I2qCHUJb418uCYfhUHZq4UmusZTiT2Pv4cMQb/o5xGtPXA== Received: from localhost.localdomain (dhcp-077-248-016-223.chello.nl [77.248.16.223]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: rakuco/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4QxVGK5MPsz180K; Thu, 6 Jul 2023 08:35:21 +0000 (UTC) (envelope-from rakuco@FreeBSD.org) Message-ID: Subject: Re: git: b56d0bc41af7 - main - devel/libcutl: Explain why USE_CXXSTD=c++11 is used From: Raphael Kubo da Costa To: "Hurling, Rainer" , eduardo@FreeBSD.org Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Date: Thu, 06 Jul 2023 10:34:57 +0200 In-Reply-To: References: <202307050850.3658oPOA049562@gitrepo.freebsd.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.48.3 (3.48.3-1.fc38) List-Id: Commit messages for all branches of the ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-all@freebsd.org X-BeenThere: dev-commits-ports-all@freebsd.org MIME-Version: 1.0 X-ThisMailContainsUnwantedMimeParts: N On Wed, 2023-07-05 at 13:39 +0200, Rainer Hurling wrote: > Hi Raphael, >=20 > This also helps me for games/eboard. I had been looking around for > some=20 > time and had not found a solution yet. I will also use parts of your=20 > explanation :) >=20 > Many thanks and best wishes, > Rainer >=20 >=20 > Am 05.07.23 um 11:13 schrieb Nuno Teixeira: > > Hello Raphael, > >=20 > > Really nice and explaining comment on std c++11 fixes. I will use > > same=20 > > comment on ports needed it to work in clang 16, e.g., net-p2p/amule > > that=20 > > needs it. > >=20 > > Just a question, should a PORTREVISION bump reccomended when we set > > USE_CXXSTD=3Dc++11? Hi both, Glad to be of help! Overall, this looks like a variation of what we had in the past especially when clang switched to C++11 by default and a lot of ports broke. Specifically in these 2 cases in case it helps: * games/eboard seems to be failing because it defines an enum called `variant` while also doing `using namespace std`, which breaks because C++17 has std::variant. * net-p2p/amule uses the `register` keyword in a bunch of places (including some autogenerated flex/bison ones that are part of the tree), and it has been removed/deprecated in C++17. As for a PORTREVISION bump: it _could_ be the case that the generated files differ now, as in the past the default standard was gnu++14 rather than c++11. For leaf ports like these two I don't think the difference really matters, but I've been semi-abstent for so long that portmgr@ or someone more active may have a better guideline.