From owner-svn-src-all@freebsd.org Sat May 12 05:31:30 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A5A5CFB464A; Sat, 12 May 2018 05:31:30 +0000 (UTC) (envelope-from allanjude@freebsd.org) Received: from mx1.scaleengine.net (mx1.scaleengine.net [209.51.186.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 1C62A8196C; Sat, 12 May 2018 05:31:30 +0000 (UTC) (envelope-from allanjude@freebsd.org) Received: from [10.1.1.2] (Seawolf.HML3.ScaleEngine.net [209.51.186.28]) (Authenticated sender: allanjude.freebsd@scaleengine.com) by mx1.scaleengine.net (Postfix) with ESMTPSA id 605AC187D6; Sat, 12 May 2018 05:31:23 +0000 (UTC) Subject: Re: svn commit: r333503 - stable/11/sys/net To: Oleksandr Tymoshenko Cc: src-committers , svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-11@freebsd.org References: <201805112040.w4BKeQvO053076@repo.freebsd.org> <1526081817.2597.5.camel@freebsd.org> <20180512051543.GA8131@bluezbox.com> From: Allan Jude Openpgp: preference=signencrypt Autocrypt: addr=allanjude@freebsd.org; prefer-encrypt=mutual; keydata= xsFNBFVwZcYBEADwrZDH0xe0ZVjc9ORCc6PcBLwS/RTXA6NkvpD6ea02pZ8lPOVgteuuugFc D34LdDbiWr+479vfrKBh+Y38GL0oZ0/13j10tIlDMHSa5BU0y6ACtnhupFvVlQ57+XaJAb/q 7qkfSiuxVwQ3FY3PL3cl1RrIP5eGHLA9hu4eVbu+FOX/q/XVKz49HaeIaxzo2Q54572VzIo6 C28McX9m65UL5fXMUGJDDLCItLmehZlHsQQ+uBxvODLFpVV2lUgDR/0rDa0B9zHZX8jY8qQ7 ZdCSy7CwClXI054CkXZCaBzgxYh/CotdI8ezmaw7NLs5vWNTxaDEFXaFMQtMVhvqQBpHkfOD 7rjjOmFw00nJL4FuPE5Yut0CPyx8vLjVmNJSt/Y8WxxmhutsqJYFgYfWl/vaWkrFLur/Zcmz IklwLw35HLsCZytCN5A3rGKdRbQjD6QPXOTJu0JPrJF6t2xFkWAT7oxnSV0ELhl2g+JfMMz2 Z1PDmS3NRnyEdqEm7NoRGXJJ7bgxDbN+9SXTyOletqGNXj/bSrBvhvZ0RQrzdHAPwQUfVSU2 qBhQEi2apSZstgVNMan0GUPqCdbE2zpysg+zT7Yhvf9EUQbzPL4LpdK1llT9fZbrdMzEXvEF oSvwJFdV3sqKmZc7b+E3PuxK6GTsKqaukd/3Cj8aLHG1T1im1QARAQABzSJBbGxhbiBKdWRl IDxhbGxhbmp1ZGVAZnJlZWJzZC5vcmc+wsF/BBMBAgApBQJVcGXGAhsjBQkSzAMABwsJCAcD AgEGFQgCCQoLBBYCAwECHgECF4AACgkQGZU1PhKYC34Muw/+JOKpSfhhysWFYiRXynGRDe07 Z6pVsn7DzrPUMRNZfHu8Uujmmy3p2nx9FelIY9yjd2UKHhug+whM54MiIFs90eCRVa4XEsPR 4FFAm0DAWrrb7qhZFcE/GhHdRWpZ341WAElWf6Puj2devtRjfYbikvj5+1V1QmDbju7cEw5D mEET44pTuD2VMRJpu2yZZzkM0i+wKFuPxlhqreufA1VNkZXI/rIfkYWK+nkXd9Efw3YdCyCQ zUgTUCb88ttSqcyhik/li1CDbXBpkzDCKI6I/8fAb7jjOC9LAtrZJrdgONywcVFoyK9ZN7EN AVA+xvYCmuYhR/3zHWH1g4hAm1v1+gIsufhajhfo8/wY1SetlzPaYkSkVQLqD8T6zZyhf+AN bC7ci44UsiKGAplB3phAXrtSPUEqM86kbnHg3fSx37kWKUiYNOnx4AC2VXvEiKsOBlpyt3dw WQbOtOYM+vkfbBwDtoGOOPYAKxc4LOIt9r+J8aD+gTooi9Eo5tvphATf9WkCpl9+aaGbSixB tUpvQMRnSMqTqq4Z7DeiG6VMRQIjsXDSLJEUqcfhnLFo0Ko/RiaHd5xyAQ4DhQ9QpkyQjjNf /3f/dYG7JAtoD30txaQ5V8uHrz210/77DRRX+HJjEj6xCxWUGvQgvEZf5XXyxeePvqZ+zQyT DX61bYw6w6bOwU0EVXBlxgEQAMy7YVnCCLN4oAOBVLZ5nUbVPvpUhsdA94/0/P+uqCIh28Cz ar56OCX0X19N/nAWecxL4H32zFbIRyDB2V/MEh4p9Qvyu/j4i1r3Ex5GhOT2hnit43Ng46z5 29Es4TijrHJP4/l/rB2VOqMKBS7Cq8zk1cWqaI9XZ59imxDNjtLLPPM+zQ1yE3OAMb475QwN UgWxTMw8rkA7CEaqeIn4sqpTSD5C7kT1Bh26+rbgJDZ77D6Uv1LaCZZOaW52okW3bFbdozV8 yM2u+xz2Qs8bHz67p+s+BlygryiOyYytpkiK6Iy4N7FTolyj5EIwCuqzfk0SaRHeOKX2ZRjC qatkgoD/t13PNT38V9tw3qZVOJDS0W6WM8VSg+F+bkM9LgJ8CmKV+Hj0k3pfGfYPOZJ/v18i +SmZmL/Uw2RghnwDWGAsPCKu4uZR777iw7n9Io6Vfxndw2dcS0e9klvFYoaGS6H2F13Asygr WBzFNGFQscN4mUW+ZYBzpTOcHkdT7w8WS55BmXYLna+dYer9/HaAuUrONjujukN4SPS1fMJ2 /CS/idAUKyyVVX5vozoNK2JVC1h1zUAVsdnmhEzNPsvBoqcVNfyqBFROEVLIPwq+lQMGNVjH ekLTKRWf59MEhUC2ztjSKkGmwdg73d6xSXMuq45EgIJV2wPvOgWQonoHH/kxABEBAAHCwWUE GAECAA8FAlVwZcYCGwwFCRLMAwAACgkQGZU1PhKYC34w5A//YViBtZyDV5O+SJT9FFO3lb9x Zdxf0trA3ooCt7gdBkdnBM6T5EmjgVZ3KYYyFfwXZVkteuCCycMF/zVw5eE9FL1+zz9gg663 nY9q2F77TZTKXVWOLlOV2bY+xaK94U4ytogOGhh9b4UnQ/Ct3+6aviCF78Go608BXbmF/GVT 7uhddemk7ItxM1gE5Hscx3saxGKlayaOsdPKeGTVJCDEtHDuOc7/+jGh5Zxpk/Hpi+DUt1ot 8e6hPYLIQa4uVx4f1xxxV858PQ7QysSLr9pTV7FAQ18JclCaMc7JWIa3homZQL/MNKOfST0S 2e+msuRwQo7AnnfFKBUtb02KwpA4GhWryhkjUh/kbVc1wmGxaU3DgXYQ5GV5+Zf4kk/wqr/7 KG0dkTz6NLCVLyDlmAzuFhf66DJ3zzz4yIo3pbDYi3HB/BwJXVSKB3Ko0oUo+6/qMrOIS02L s++QE/z7K12CCcs7WwOjfCYHK7VtE0Sr/PfybBdTbuDncOuAyAIeIKxdI2nmQHzl035hhvQX s4CSghsP319jAOQiIolCeSbTMD4QWMK8RL/Pe1FI1jC3Nw9s+jq8Dudtbcj2UwAP/STUEbJ9 5rznzuuhPjE0e++EU/RpWmcaIMK/z1zZDMN+ce2v1qzgV936ZhJ3iaVzyqbEE81gDxg3P+IM kiYh4ZtPB4Q= Message-ID: <5db6b500-8c4c-d171-4418-5e25c510f66d@freebsd.org> Date: Sat, 12 May 2018 01:31:19 -0400 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <20180512051543.GA8131@bluezbox.com> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="uV4rTWLqWNWce1EYzanASLYijBtBCJsF4" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 12 May 2018 05:31:30 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --uV4rTWLqWNWce1EYzanASLYijBtBCJsF4 Content-Type: multipart/mixed; boundary="NAX9ZmWMvFU6YjSjjjXX16y2OBGHrOGf8"; protected-headers="v1" From: Allan Jude To: Oleksandr Tymoshenko Cc: src-committers , svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-11@freebsd.org Message-ID: <5db6b500-8c4c-d171-4418-5e25c510f66d@freebsd.org> Subject: Re: svn commit: r333503 - stable/11/sys/net References: <201805112040.w4BKeQvO053076@repo.freebsd.org> <1526081817.2597.5.camel@freebsd.org> <20180512051543.GA8131@bluezbox.com> In-Reply-To: <20180512051543.GA8131@bluezbox.com> --NAX9ZmWMvFU6YjSjjjXX16y2OBGHrOGf8 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 2018-05-12 01:15, Oleksandr Tymoshenko wrote: > Ian Lepore (ian@freebsd.org) wrote: >> On Fri, 2018-05-11 at 19:31 -0400, Jonathan T. Looney wrote: >>> On Fri, May 11, 2018 at 4:40 PM, Stephen Hurd wro= te: >>>> >>>> >>>> Author: shurd >>>> Date: Fri May 11 20:40:26 2018 >>>> New Revision: 333503 >>>> URL: https://svnweb.freebsd.org/changeset/base/333503 >>>> >>>> Log: >>>> =C2=A0 MFC r333329, r333366, r333373 >>>> >>>> =C2=A0 r333329: Fix off-by-one error requesting tx interrupt >>>> =C2=A0 r333366: Cleanup queues when iflib_device_register fails >>>> =C2=A0 r333373: Log iflib_tx_structures_setup failure in function >>>> >>> Is this an acceptable style for MFC logs? >>> >>> I'm asking because I actually prefer this to reading (or compiling) t= he >>> concatenated log messages from several changes. However, I never knew= it >>> was acceptable to summarize like this. If it is, I'd like to know so = I can >>> adopt it for run-of-the-mill MFCs. >>> >>> Jonathan >> >> This used to be my preferred format, essentially to summarize what's >> being mfc'd. But then I started using the MFC Tracker tool [*] and it >> automatically generates a commit message that contains the full text, >> so I stopped trying to summarize things. >=20 > I've just deployed new mfctracker version with summarized MFC commit > message support so users can now switch between full MFC log and a > short version. Of course it's only useful if selected commits have > one-line summary in the first line of a commit message. > =20 >> [*]=C2=A0https://mfc.kernelnomicon.org/6/ >> >> -- Ian >=20 Thank you for building and constantly improving this extremely useful too= l. --=20 Allan Jude --NAX9ZmWMvFU6YjSjjjXX16y2OBGHrOGf8-- --uV4rTWLqWNWce1EYzanASLYijBtBCJsF4 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (MingW32) iQIcBAEBAgAGBQJa9nwqAAoJEBmVNT4SmAt+AgIQAJ2QnpbuJwU+t3DmUbR0Tj0K 9oB6JE+EXisoXaQ5rI1LgnIzbSxbVFeUhwS4WGJxuqhNarS6XO1EuZgYgNeOW1oi 1e3wAWoqwsJQtHhJ21OqD4Gvc0KRTlb2P5so2kxNgExwpC8lZ/fXE7e3L5H5ucfN ysG3c9xp8MfmR0Xb17wdV3cfhwNAFBuyQuN9ndwhpqVddl5l6rg3nr82qWQOvb1I q5sYiZ7rSJ05+QHEOiy+yPwT0lBvSdNXbaBIKOvA2W6HzpqGOL6voZ7zK9ALZAMI 1VWKEXs8CEWNfB7PAuWemqpMjXSDJ39gmsyRqu93B9g5J7BPfupJa6/uWiY8PKxG gH3Uy/xlxUJBV+MOfGf39OtC2E3Dnu0mOL+G6XjCKruWhHyT3RgNVlyfNTkes1IR X8+O7DRozOYhBawMtDcl0Cr3J8mkL+p3jIAL+RWrapz76+02yoAeBGJzmKw2z1Vo zp9u8CWxQiLGG9wxqcbm+HoaLZb6iUlxNqt1tWlc26qqb614p0eyb8d1LogeKU2K ufkDCob8hUcqBnpzVoD+57CPP5yJformnWQiTZpEbXN+8SL3MpJXjH1SpvsmfisF CpZBTYTpNGV2MgjIYgfPHp3LalV9zJfri4tp2NlWD6N9fkhT6kJAxa1R5shf5JO9 hYOhzIgB8Q+EAqOfztDi =O8eA -----END PGP SIGNATURE----- --uV4rTWLqWNWce1EYzanASLYijBtBCJsF4--