From owner-freebsd-bugs  Thu Jan 22 19:50:02 1998
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Received: (from majordom@localhost)
          by hub.freebsd.org (8.8.8/8.8.8) id TAA22423
          for freebsd-bugs-outgoing; Thu, 22 Jan 1998 19:50:02 -0800 (PST)
          (envelope-from owner-freebsd-bugs@FreeBSD.ORG)
Received: (from gnats@localhost)
          by hub.freebsd.org (8.8.8/8.8.8) id TAA22414;
          Thu, 22 Jan 1998 19:50:01 -0800 (PST)
          (envelope-from gnats)
Received: from vpc20.bellcore.com (vpc20.bellcore.com [192.4.4.95])
          by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id TAA21928
          for <FreeBSD-gnats-submit@freebsd.org>; Thu, 22 Jan 1998 19:45:33 -0800 (PST)
          (envelope-from ath@vpc20.bellcore.com)
Received: (from ath@localhost)
	by vpc20.bellcore.com (8.8.7/8.8.7) id WAA24807;
	Thu, 22 Jan 1998 22:44:54 -0500 (EST)
	(envelope-from ath)
Message-Id: <199801230344.WAA24807@vpc20.bellcore.com>
Date: Thu, 22 Jan 1998 22:44:54 -0500 (EST)
From: ath@bellcore.com
Reply-To: ath@bellcore.com
To: FreeBSD-gnats-submit@FreeBSD.ORG
X-Send-Pr-Version: 3.2
Subject: bin/5551: iijppp does not allow a filter for any established tcp packet
Sender: owner-freebsd-bugs@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.org


>Number:         5551
>Category:       bin
>Synopsis:       iijppp does not allow a filter for any established tcp packet
>Confidential:   yes
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:
>Keywords:
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Thu Jan 22 19:50:00 PST 1998
>Last-Modified:
>Originator:     Andrew Heybey
>Organization:
>Release:        FreeBSD 2.2.5-RELEASE i386
>Environment:

	Using iijppp to filter packets.

>Description:

	The man page for ppp implies that a filter of the form:
	  <action> tcp estab
	should work.  However, it is rejected as a syntax error by the parser.

>How-To-Repeat:

	Put a line such as
	  ifilter 0 permit tcp estab
	in /etc/ppp/ppp.conf

>Fix:

*** filter.c	1998/01/23 03:38:16	1.1
--- filter.c	1998/01/23 03:38:33
***************
*** 202,208 ****
      filterdata.opt.srcop = filterdata.opt.dstop = A_NONE;
      return (1);
    }
!   if (argc < 3) {
      LogPrintf(LogWARN, "ParseUdpOrTcp: bad udp/tcp syntax.\n");
      return (0);
    }
--- 202,208 ----
      filterdata.opt.srcop = filterdata.opt.dstop = A_NONE;
      return (1);
    }
!   if (argc < 3 && argc != 1) {
      LogPrintf(LogWARN, "ParseUdpOrTcp: bad udp/tcp syntax.\n");
      return (0);
    }
>Audit-Trail:
>Unformatted: