From owner-freebsd-current@FreeBSD.ORG Mon Nov 16 18:06:01 2009 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C28491065695 for ; Mon, 16 Nov 2009 18:06:01 +0000 (UTC) (envelope-from gnemmi@gmail.com) Received: from mail-yw0-f178.google.com (mail-yw0-f178.google.com [209.85.211.178]) by mx1.freebsd.org (Postfix) with ESMTP id 763388FC1C for ; Mon, 16 Nov 2009 18:06:01 +0000 (UTC) Received: by ywh8 with SMTP id 8so5172526ywh.3 for ; Mon, 16 Nov 2009 10:06:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:from:to:subject:date :user-agent:cc:references:in-reply-to:mime-version:content-type :content-transfer-encoding:content-disposition:message-id; bh=wQaLz8fvvLBFAhjuMj6E0LhykjpbVxRDI3MwXv79Kg4=; b=qpdBFVBWPCo7UzQZSlpm66u0kyNmR+j5Vo/8AW4jplzIjahE+QXbp851ibIVVXyaDj mIX0umAaFu9Oi4aTUY1JlfuxOm9OOCRNQ7nGJ6GjtnUepzS3t7miWpdun34TkpK5zGyt Li/RybBCzBbphjIqRLbi/Ky17CGOPu7yYSp6U= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:subject:date:user-agent:cc:references:in-reply-to :mime-version:content-type:content-transfer-encoding :content-disposition:message-id; b=FxMTUhtnfKtnH509P7dry26s3Dv8B2uxQquRyWtnH/2qvGTZtiYdZpyvO9peKm7GLn STBhA/ETW45Z7klj/tEtA842P/X/PLYqfM12nHURSO6d+DCJKBF3P7HyzTK7xgXp8j0V kpmtlEjx3q6urAG/nceTyCdzV7EhQvsn7jTbY= Received: by 10.101.142.31 with SMTP id u31mr893003ann.159.1258394757218; Mon, 16 Nov 2009 10:05:57 -0800 (PST) Received: from ?192.168.1.101? ([190.177.192.49]) by mx.google.com with ESMTPS id 35sm1743416yxh.33.2009.11.16.10.05.55 (version=TLSv1/SSLv3 cipher=RC4-MD5); Mon, 16 Nov 2009 10:05:56 -0800 (PST) From: Gonzalo Nemmi To: pyunyh@gmail.com Date: Mon, 16 Nov 2009 16:05:53 -0200 User-Agent: KMail/1.9.10 References: <20091111223751.GE15449@michelle.cdnetworks.com> <200911161534.34028.gnemmi@gmail.com> <20091116175450.GB1262@michelle.cdnetworks.com> In-Reply-To: <20091116175450.GB1262@michelle.cdnetworks.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200911161605.53577.gnemmi@gmail.com> Cc: freebsd-current@freebsd.org Subject: Re: Call for bge(4) testers X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Nov 2009 18:06:01 -0000 On Monday 16 November 2009 3:54:50 pm Pyun YongHyeon wrote: > On Mon, Nov 16, 2009 at 03:34:33PM -0200, Gonzalo Nemmi wrote: > > On Sunday 15 November 2009 11:58:16 pm Pyun YongHyeon wrote: > > > On Thu, Nov 12, 2009 at 08:39:31PM -0200, Gonzalo Nemmi wrote: > > > > On Thursday 12 November 2009 8:05:50 pm Pyun YongHyeon wrote: > > > > > On Thu, Nov 12, 2009 at 07:12:44PM -0200, Gonzalo Nemmi wrote: > > > > > > On Thursday 12 November 2009 1:47:49 am Pyun YongHyeon wrote: > > > > > > > On Wed, Nov 11, 2009 at 02:37:51PM -0800, Pyun YongHyeon > > > > wrote: > > > > > > > > Hi, > > > > > > > > > > > > > > > > I had been working on fixing bus_dma(9) bugs and adding > > > > > > > > TSO capability to bge(4). Now TSO is supported for > > > > > > > > BCM5755 or newer controllers. Actually some pre-BCM5755 > > > > > > > > controllers also support TSO with the help of special > > > > > > > > firmware but the license issue and lower performance of > > > > > > > > firmware based TSO as well as TSO bug I intentionally > > > > > > > > excluded TSO support for pre-BCM5755 controllers. You > > > > > > > > can get the patch form the following URL. The diff was > > > > > > > > generated against latest HEAD. > > > > > > > > > > > > > > > > http://people.freebsd.org/~yongari/bge/bge.tso.1111.dif > > > > > > > >f > > > > > > > > > > > > > > Eh, there was a typo so I regenerated the diff. > > > > > > > http://people.freebsd.org/~yongari/bge/bge.tso.1111-1.dif > > > > > > >f > > > > > > > > > > > > Hi > > > > > > Just wanted to know before getting on to it, will your > > > > > > patch help to resolve kern/136876? > > > > > > > > > > My diff includes a fix for assuming PCIe device control > > > > > register and MSI control registers would be reside in fixed > > > > > address. And from the pciconf output I see the your MSI > > > > > control register is located at different address. However > > > > > bge(4) does not touch that register for BCM5906 so I guess my > > > > > diff may not fix the resume issue. > > > > > > > > Thanks a lot for your prompt, clear and straight answer. > > > > > > Would you try attached patch for BCM5906 resume issue? Not sure > > > whether it help or not though. > > > > Hi Pyun! > > Sorry for the delay, I was out of town and just got back. > > I'm downloading RC3 as of now. Then I will install: > > edit make.conf > > edit src.conf > > buildworld > > buildkernel > > installkernel > > reboot > > > > mergemaster -p > > make installworld > > reboot > > > > cp bge.diff bge.patch > > cd /usr/src/sys/dev/bge && patch < /path/to/patch > > make > > make install clean > > kldunload if_bge > > Not sure you removed bge in GENERIC kernel configuration file. Oh! Sorry for not being clear on that point. Due to the problems I've had with bge(4), I do remove it from GENERIC .. Actually .. most of my kernels are named NOBGE ;) > > kldload if_bge > > pciconf -lcvb > > ifconfig bge0 up > > acpiconf -s3 > > > > ... and hpefully .. resume from S3 .. > > > > Is that ok with you or would you like me to do it in another way? > > That's ok. At first I wanted to add WOL to wake up bge(4) with > magic packet but bge(4) seems to require a lot of workaround for > each controller and it's too complex to implement at this time. > Just want to know whether bge(4) can resume from suspend. Perfetc then, I'll proceed as described above and mail you back as soon as I have some results to let you know :) Once Again, thanks for the patch Pyun :) Best Regards Gonzalo Nemmi > > try some more stuff? > > Some test in particular? > > > > Best Regards and thanks for the patch > > Gonzalo Nemmi