From owner-freebsd-stable@FreeBSD.ORG Wed Sep 17 17:43:44 2008 Return-Path: Delivered-To: freebsd-stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 773AA1065715 for ; Wed, 17 Sep 2008 17:43:44 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (bigknife-pt.tunnel.tserv9.chi1.ipv6.he.net [IPv6:2001:470:1f10:75::2]) by mx1.freebsd.org (Postfix) with ESMTP id EEC318FC23 for ; Wed, 17 Sep 2008 17:43:43 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from localhost.corp.yahoo.com (john@localhost [IPv6:::1]) (authenticated bits=0) by server.baldwin.cx (8.14.2/8.14.2) with ESMTP id m8HHhL6J007809; Wed, 17 Sep 2008 13:43:37 -0400 (EDT) (envelope-from jhb@freebsd.org) From: John Baldwin To: freebsd-stable@freebsd.org Date: Wed, 17 Sep 2008 11:44:48 -0400 User-Agent: KMail/1.9.7 References: <200809171147.m8HBlI7F082370@lurza.secnetix.de> In-Reply-To: <200809171147.m8HBlI7F082370@lurza.secnetix.de> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200809171144.48424.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [IPv6:::1]); Wed, 17 Sep 2008 13:43:38 -0400 (EDT) X-Virus-Scanned: ClamAV 0.93.1/8270/Wed Sep 17 09:15:56 2008 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-2.5 required=4.2 tests=AWL,BAYES_00,NO_RELAYS autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: Oliver Fromme Subject: Re: ACPI "blacklist" question X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Sep 2008 17:43:44 -0000 On Wednesday 17 September 2008 07:47:18 am Oliver Fromme wrote: > Hello, > > I have recently updated a machine to 7-stable. > ACPI doesn't seem to work correctly on this machine. > With earlier versions of FreeBSD (including the latest > RELENG_6), I got this line in dmesg: > > ACPI disabled by blacklist. Contact your BIOS vendor. > > And everything was fine. The box runs perfectly well > with ACPI disabled. (I can't get a BIOS update because > the mainboard is too old.) > > When I updated to RELENG_7 a few days ago, the above line > did _not_ appear anymore, and the machine didn't proceed > to boot, so I had to travel to the console. :-( > After disabling ACPI manually via boot.conf hint, it is > up and running fine again. > > Now i'm wondering: Has the ACPI blacklist been removed > intentionally, or is this a regression? Certainly I did > not find any mentioning of it in UPDATING or anywhere > else. This is a regression. Try this fix: Index: acpi_quirk.c =================================================================== --- acpi_quirk.c (revision 183112) +++ acpi_quirk.c (working copy) @@ -149,9 +149,9 @@ if (ACPI_FAILURE(AcpiGetTableHeader(ACPI_SIG_FADT, 0, &fadt))) bzero(&fadt, sizeof(fadt)); if (ACPI_FAILURE(AcpiGetTableHeader(ACPI_SIG_DSDT, 0, &dsdt))) - bzero(&fadt, sizeof(dsdt)); + bzero(&dsdt, sizeof(dsdt)); if (ACPI_FAILURE(AcpiGetTableHeader(ACPI_SIG_XSDT, 0, &xsdt))) - bzero(&fadt, sizeof(xsdt)); + bzero(&xsdt, sizeof(xsdt)); /* Then, override the quirks with any matched from table signatures. */ for (entry = acpi_quirks_table; entry->match; entry++) { -- John Baldwin