From owner-svn-src-head@freebsd.org Sun Dec 13 18:57:08 2020 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id BBE194C0AAE; Sun, 13 Dec 2020 18:57:08 +0000 (UTC) (envelope-from se@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4CvDKJ4vd9z4l7f; Sun, 13 Dec 2020 18:57:08 +0000 (UTC) (envelope-from se@freebsd.org) Received: from Stefans-MBP-WLAN.fritz.box (p200300cd5f1a9b0054962bf042eefcc0.dip0.t-ipconnect.de [IPv6:2003:cd:5f1a:9b00:5496:2bf0:42ee:fcc0]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) (Authenticated sender: se/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id F33FA9BEA; Sun, 13 Dec 2020 18:57:07 +0000 (UTC) (envelope-from se@freebsd.org) To: Yuri Pankov References: <202012130938.0BD9cpTp041055@repo.freebsd.org> From: Stefan Esser Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r368606 - head/usr.bin/calendar Message-ID: <3dad51fd-ce00-99e2-e83a-fa4c18e6bfce@freebsd.org> Date: Sun, 13 Dec 2020 19:57:05 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.16; rv:78.0) Gecko/20100101 Thunderbird/78.5.1 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="I04qkHyLSvATaJOyKYAw0dSgjqSDPElBv" X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 13 Dec 2020 18:57:08 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --I04qkHyLSvATaJOyKYAw0dSgjqSDPElBv Content-Type: multipart/mixed; boundary="7Z581B1MjGYPd68vZ9am94BCVLlFBCfqK"; protected-headers="v1" From: Stefan Esser To: Yuri Pankov Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Message-ID: <3dad51fd-ce00-99e2-e83a-fa4c18e6bfce@freebsd.org> Subject: Re: svn commit: r368606 - head/usr.bin/calendar References: <202012130938.0BD9cpTp041055@repo.freebsd.org> In-Reply-To: --7Z581B1MjGYPd68vZ9am94BCVLlFBCfqK Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable Am 13.12.20 um 12:13 schrieb Yuri Pankov: > Stefan E=C3=9Fer wrote: >> Author: se >> Date: Sun Dec 13 09:38:50 2020 >> New Revision: 368606 >> URL: https://svnweb.freebsd.org/changeset/base/368606 >> >> Log: >> =C2=A0=C2=A0 Fix WITHOUT_ICONV build >> =C2=A0=C2=A0 There was an unprotected use of nl_langinfo() to determin= e the=20 >> order of >> =C2=A0=C2=A0 day vs. month in the generated output. >=20 > That's strange, nl_langinfo() is standard and its visibility should not= =20 > (and does not?) depend on WITH/WITHOUT_ICONV.=C2=A0 May be just move=20 > langinfo.h include outside of "#ifdef WITH_ICONV" block? Yes, you are perfectly right ... I had noticed that WITHOUT_ICONV lead to a problem due to the missing=20 prototype, but I had not seen that this was due to the include of langinfo.h being conditional on WITH_ICONV. I'll revert this commit and move the include of langinfo.h out of the conditional block, as suggested by you. Thanks for pointing this out! Best regards, STefan --7Z581B1MjGYPd68vZ9am94BCVLlFBCfqK-- --I04qkHyLSvATaJOyKYAw0dSgjqSDPElBv Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wsB5BAABCAAjFiEEo3HqZZwL7MgrcVMTR+u171r99UQFAl/WZAEFAwAAAAAACgkQR+u171r99UR6 MAgAuImw4Y0y+GDlerwKn4/l5GS0rFaipOtmyIP3w/bDQmDoIuB23n7jjfdQQF051BvRi9CWVEof wpngvE6O8LavM9B/WIedi2s9tR9sQyAiPMUTDfnbBgJ+VxBM+WYd0aNNeeJss5i6Itmw8MSg187j TjZl++15uX9wu4EnL5itAiZWqX0rS0+nyxMkFsuW+r7NBubNheA+Zp9+JaZqF3UnH9Q8c8JwDIjf xhcJQzK53F2YBVnUu5GW20044WFp+9lazQJyG3Bb5RmnaKftaO1OUzRnnHOT7TNv+nJ3fMyiAeA/ hGi0UeeA4dE4BkT56ull+gcam4lSJ9T3P1A6iTiNRQ== =oyw3 -----END PGP SIGNATURE----- --I04qkHyLSvATaJOyKYAw0dSgjqSDPElBv--