From owner-cvs-all@FreeBSD.ORG Mon Mar 31 01:34:09 2003 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3FF6737B401; Mon, 31 Mar 2003 01:34:09 -0800 (PST) Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.86.163]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3ED6A43FA3; Mon, 31 Mar 2003 01:34:08 -0800 (PST) (envelope-from phk@phk.freebsd.dk) Received: from critter.freebsd.dk (localhost [127.0.0.1]) by critter.freebsd.dk (8.12.8/8.12.8) with ESMTP id h2V9Y0SM022299; Mon, 31 Mar 2003 11:34:06 +0200 (CEST) (envelope-from phk@phk.freebsd.dk) To: Bruce Evans From: "Poul-Henning Kamp" In-Reply-To: Your message of "Mon, 31 Mar 2003 15:13:43 +1000." <20030331140740.R17363@gamplex.bde.org> Date: Mon, 31 Mar 2003 11:34:00 +0200 Message-ID: <22298.1049103240@critter.freebsd.dk> cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org cc: Nate Lawson Subject: Re: cvs commit: src/sbin/fdisk fdisk.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 31 Mar 2003 09:34:11 -0000 In message <20030331140740.R17363@gamplex.bde.org>, Bruce Evans writes: >This is more broken than I thought. fdisk now defaults to a wrong geometry >in all cases where the BIOS geometry differs from the firmware geometry. > >The default geometry was H=1/S=1 or whatever is returned by DIOCGDINFO >until this was broken in -current. This is still non-broken in RELENG_4. I don't particularly care for what numbers we use, but I do not want a lot of elaborate DWIM code since in this particular case the user had better know exactly what she is doing anyway. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence.