From owner-freebsd-current@FreeBSD.ORG Thu Apr 27 14:18:03 2006 Return-Path: X-Original-To: freebsd-current@FreeBSD.org Delivered-To: freebsd-current@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id F3D7C16A408; Thu, 27 Apr 2006 14:18:02 +0000 (UTC) (envelope-from keramida@FreeBSD.org) Received: from igloo.linux.gr (igloo.linux.gr [62.1.205.36]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1773C43D4C; Thu, 27 Apr 2006 14:17:59 +0000 (GMT) (envelope-from keramida@FreeBSD.org) Received: from gothmog.pc (aris.bedc.ondsl.gr [62.103.39.226]) (authenticated bits=128) by igloo.linux.gr (8.13.6/8.13.6/Debian-1) with ESMTP id k3REHjFo016844 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Thu, 27 Apr 2006 17:17:46 +0300 Received: from gothmog.pc (gothmog [127.0.0.1]) by gothmog.pc (8.13.6/8.13.6) with ESMTP id k3REHkML074387; Thu, 27 Apr 2006 17:17:46 +0300 (EEST) (envelope-from keramida@FreeBSD.org) Received: (from giorgos@localhost) by gothmog.pc (8.13.6/8.13.6/Submit) id k3REHkuL074386; Thu, 27 Apr 2006 17:17:46 +0300 (EEST) (envelope-from keramida@FreeBSD.org) Date: Thu, 27 Apr 2006 17:17:46 +0300 From: Giorgos Keramidas To: Jiawei Ye Message-ID: <20060427141745.GA74340@gothmog.pc> References: <20060427141318.GA74140@gothmog.pc> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="J2SCkAp4GZ/dPZZf" Content-Disposition: inline In-Reply-To: <20060427141318.GA74140@gothmog.pc> X-Hellug-MailScanner: Found to be clean X-Hellug-MailScanner-SpamCheck: not spam, SpamAssassin (score=-3.776, required 5, autolearn=not spam, ALL_TRUSTED -1.80, AWL 0.62, BAYES_00 -2.60) X-Hellug-MailScanner-From: keramida@freebsd.org X-Spam-Status: No Cc: John-Mark Gurney , freebsd-current@FreeBSD.org Subject: Re: top(1) stopped working on -current X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 Apr 2006 14:18:03 -0000 --J2SCkAp4GZ/dPZZf Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On 2006-04-27 17:13, Giorgos Keramidas wrote: > # --- src/sys/kern/sched_4bsd.c (revision 19) > # +++ src/sys/kern/sched_4bsd.c (working copy) > # @@ -31,11 +31,11 @@ > # * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF > # * SUCH DAMAGE. > # */ > # > # #include > # -__FBSDID("$FreeBSD: src/sys/kern/sched_4bsd.c,v 1.78 2006/04/17 18:20:37 jhb Exp $"); > # +__FBSDID("$FreeBSD: src/sys/kern/sched_4bsd.c,v 1.79 2006/04/26 19:42:38 jmg Exp $"); > # > # [...] > > The main problems with this change are: > > 1) It doesn't update consumers of the kern.ccpu sysctl that we > already have in the tree (i.e. top(1) which you saw breaking). FWIW, the current consumers of `kern.ccpu' are: giorgos@gothmog:~/ws/bsd/src$ fgrep -r kern.ccpu . ./bin/ps/nlist.c: if (sysctlbyname("kern.ccpu", &ccpu, &oldlen, NULL, 0) == -1) ./usr.bin/systat/pigs.c: err = sysctlbyname("kern.ccpu", &ccpu, &len, NULL, 0); ./usr.bin/systat/pigs.c: perror("kern.ccpu"); ./usr.bin/top/machine.c: GETSYSCTL("kern.ccpu", ccpu); ./usr.sbin/bsnmpd/modules/snmp_hostres/hostres_processor_tbl.c: if (sysctlbyname("kern.ccpu", &ccpu, &len, NULL, 0) == -1) { ./usr.sbin/bsnmpd/modules/snmp_hostres/hostres_processor_tbl.c: syslog(LOG_ERR, "hrProcessorTable: sysctl(kern.ccpu) failed"); giorgos@gothmog:~/ws/bsd/src$ --J2SCkAp4GZ/dPZZf Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.3 (FreeBSD) iD8DBQFEUNKJ1g+UGjGGA7YRAk1SAKC8VhEL8q6SmmvF+aCmzQs7LC/8XACgh/t3 D4Xl1HvnuD6oAPnm4Larnlo= =QSmm -----END PGP SIGNATURE----- --J2SCkAp4GZ/dPZZf--