From owner-p4-projects@FreeBSD.ORG  Wed Jan 31 08:59:11 2007
Return-Path: <owner-p4-projects@FreeBSD.ORG>
X-Original-To: p4-projects@freebsd.org
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 19F9A16A405; Wed, 31 Jan 2007 08:59:11 +0000 (UTC)
X-Original-To: perforce@freebsd.org
Delivered-To: perforce@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 97E0216A402;
	Wed, 31 Jan 2007 08:59:10 +0000 (UTC)
	(envelope-from xdivac02@stud.fit.vutbr.cz)
Received: from eva.fit.vutbr.cz (eva.fit.vutbr.cz [147.229.176.14])
	by mx1.freebsd.org (Postfix) with ESMTP id 2B2E213C442;
	Wed, 31 Jan 2007 08:59:07 +0000 (UTC)
	(envelope-from xdivac02@stud.fit.vutbr.cz)
Received: from eva.fit.vutbr.cz (localhost [127.0.0.1])
	by eva.fit.vutbr.cz (envelope-from xdivac02@eva.fit.vutbr.cz)
	(8.13.8/8.13.7) with ESMTP id l0V8x6hi028284
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);
	Wed, 31 Jan 2007 09:59:06 +0100 (CET)
Received: (from xdivac02@localhost)
	by eva.fit.vutbr.cz (8.13.8/8.13.3/Submit) id l0V8x6pt028283;
	Wed, 31 Jan 2007 09:59:06 +0100 (CET)
Date: Wed, 31 Jan 2007 09:59:06 +0100
From: Divacky Roman <xdivac02@stud.fit.vutbr.cz>
To: Jung-uk Kim <jkim@freebsd.org>
Message-ID: <20070131085906.GA28186@stud.fit.vutbr.cz>
References: <200701310016.l0V0GccJ095661@repoman.freebsd.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200701310016.l0V0GccJ095661@repoman.freebsd.org>
User-Agent: Mutt/1.4.2.2i
X-Scanned-By: MIMEDefang 2.57 on 147.229.176.14
Cc: Perforce Change Reviews <perforce@freebsd.org>
Subject: Re: PERFORCE change 113739 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 31 Jan 2007 08:59:11 -0000

On Wed, Jan 31, 2007 at 12:16:38AM +0000, Jung-uk Kim wrote:
> http://perforce.freebsd.org/chv.cgi?CH=113739
> 
> Change 113739 by jkim@jkim_hammer on 2007/01/31 00:15:36
> 
> 	Do not reload %gs from linux_*sigcode().
> 	This seem to fix TLS on amd64, finally. :-)
> 	
> 	Tested on UP and QEMU.  Need more testing on SMP.
> 
> Affected files ...
> 
> .. //depot/projects/linuxolator/src/sys/amd64/linux32/linux32_locore.s#2 edit
> 
> Differences ...
> 
> ==== //depot/projects/linuxolator/src/sys/amd64/linux32/linux32_locore.s#2 (text+ko) ====
> 
> @@ -11,7 +11,9 @@
>  NON_GPROF_ENTRY(linux_sigcode)
>  	call	*LINUX_SIGF_HANDLER(%esp)
>  	leal	LINUX_SIGF_SC(%esp),%ebx	/* linux scp */
> +#if 0
>  	movl	LINUX_SC_GS(%ebx),%gs
> +#endif
>  	movl	LINUX_SC_FS(%ebx),%fs
>  	movl	LINUX_SC_ES(%ebx),%es
>  	movl	LINUX_SC_DS(%ebx),%ds
> @@ -25,7 +27,9 @@
>  linux_rt_sigcode:
>  	call	*LINUX_RT_SIGF_HANDLER(%esp)
>  	leal	LINUX_RT_SIGF_UC(%esp),%ebx	/* linux ucp */
> +#if 0
>  	movl	LINUX_SC_GS(%ebx),%gs
> +#endif

great work! why didnt you just remove those lines but if 0 them? without
commit it looks a little strange to someone who doesnt know why/where/how :)