From owner-freebsd-current@FreeBSD.ORG Mon Sep 15 22:09:56 2008 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D9981106566C for ; Mon, 15 Sep 2008 22:09:56 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (bigknife-pt.tunnel.tserv9.chi1.ipv6.he.net [IPv6:2001:470:1f10:75::2]) by mx1.freebsd.org (Postfix) with ESMTP id 615C68FC14 for ; Mon, 15 Sep 2008 22:09:56 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from localhost.corp.yahoo.com (john@localhost [IPv6:::1]) (authenticated bits=0) by server.baldwin.cx (8.14.2/8.14.2) with ESMTP id m8FM9bCK083996; Mon, 15 Sep 2008 18:09:50 -0400 (EDT) (envelope-from jhb@freebsd.org) From: John Baldwin To: Marcel Moolenaar Date: Mon, 15 Sep 2008 18:08:33 -0400 User-Agent: KMail/1.9.7 References: <48CE59C2.9060307@icyb.net.ua> <48CEBF42.3060901@icyb.net.ua> <1A6B5018-ABC9-4612-A66A-1A6D21336619@mac.com> In-Reply-To: <1A6B5018-ABC9-4612-A66A-1A6D21336619@mac.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200809151808.33400.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [IPv6:::1]); Mon, 15 Sep 2008 18:09:50 -0400 (EDT) X-Virus-Scanned: ClamAV 0.93.1/8251/Mon Sep 15 16:23:40 2008 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-2.5 required=4.2 tests=AWL,BAYES_00,NO_RELAYS autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: freebsd-current@freebsd.org, Andriy Gapon Subject: Re: sio => uart: one port is gone X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Sep 2008 22:09:56 -0000 On Monday 15 September 2008 04:11:14 pm Marcel Moolenaar wrote: > > On Sep 15, 2008, at 1:02 PM, Andriy Gapon wrote: > > > --- a/sys/conf/files > > +++ b/sys/conf/files > > @@ -1080,7 +1080,7 @@ dev/twe/twe.c optional twe > > dev/twe/twe_freebsd.c optional twe > > dev/tx/if_tx.c optional tx > > dev/txp/if_txp.c optional txp > > -dev/uart/uart_bus_acpi.c optional uart acpi > > +dev/uart/uart_bus_acpi.c optional uart > > #dev/uart/uart_bus_cbus.c optional uart cbus > > dev/uart/uart_bus_ebus.c optional uart ebus > > dev/uart/uart_bus_isa.c optional uart isa > > This is exactly the thing we shouldn't be doing. > > You now compile the acpi bus attachment on platforms > that don't even have acpi. This is not a fix, it's > a breakage... You can change it in sys/conf/files.i386 instead. (It's ok to have duplicate lines across files*, the file gets compiled in if any one of the conditions matches). -- John Baldwin