From owner-freebsd-net@FreeBSD.ORG Wed Jan 28 18:55:20 2015 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 91D24802 for ; Wed, 28 Jan 2015 18:55:20 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [IPv6:2001:4f8:3:ffe0:406a:0:50:2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 5319BC28 for ; Wed, 28 Jan 2015 18:55:20 +0000 (UTC) Received: from phabric-backend.isc.freebsd.org (phabric-backend.isc.freebsd.org [127.0.1.5]) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9) with ESMTP id t0SItKrV079856 for ; Wed, 28 Jan 2015 18:55:20 GMT (envelope-from mat@phabric-backend.isc.freebsd.org) Received: (from root@localhost) by phabric-backend.isc.freebsd.org (8.14.9/8.14.9/Submit) id t0SItKBC079854; Wed, 28 Jan 2015 18:55:20 GMT (envelope-from mat) Date: Wed, 28 Jan 2015 18:55:20 +0000 To: freebsd-net@freebsd.org From: "hselasky (Hans Petter Selasky)" Subject: [Differential] [Requested Changes To] D1711: Changes to the callout code to restore active semantics and also add a test-framework and test to validate thecallout code (and potentially for use by other tests). Message-ID: X-Priority: 3 Thread-Topic: D1711: Changes to the callout code to restore active semantics and also add a test-framework and test to validate the callout code (and potentially for use by other tests). X-Herald-Rules: none X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-To: X-Phabricator-Cc: X-Phabricator-Cc: X-Phabricator-Cc: In-Reply-To: References: Thread-Index: Y2JjMTcyODJkYzgxM2NkZDFjY2RhOGRmMTlkIFTJMJg= X-Phabricator-Sent-This-Message: Yes X-Mail-Transport-Agent: MetaMTA X-Auto-Response-Suppress: All X-Phabricator-Mail-Tags: , , MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="utf-8" X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Jan 2015 18:55:20 -0000 hselasky requested changes to this revision. hselasky added a comment. This revision now requires changes to proceed. See comments given. INLINE COMMENTS sys/kern/kern_timeout.c:674 cc_exec_cancel(cc, direct) should be true when c_lock == NULL, because the callback cannot be stopped then. sys/kern/kern_timeout.c:1059 Is this comment be properly formatted with regard to filling lines till end of line? ALT+Q in emacs?? sys/modules/callout_test/callout_test.c:58 Should these variables all be static? sys/modules/callout_test/callout_test.c:69 Possibly this define is redundant. sys/modules/callout_test/callout_test.c:254 Is this check really needed? sys/sys/callout_test.h:1 Upper case inclusion guard. sys/sys/callout_test.h:1 Missing copyright for header file. sys/sys/kern_testfrwk.h:43 Should this function be typedefed: typedef void (kern_testframework_func_t)(struct kern_test *); REVISION DETAIL https://reviews.freebsd.org/D1711 To: rrs, gnn, rwatson, imp, adrian, sbruno, lstewart, hselasky Cc: neel, erj, freebsd-net