From nobody Wed Dec 15 11:16:44 2021 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 5D15418E9B14; Wed, 15 Dec 2021 11:16:46 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4JDXkh5hJ4z4qtM; Wed, 15 Dec 2021 11:16:44 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 47E441ADFA; Wed, 15 Dec 2021 11:16:44 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 1BFBGiBu081671; Wed, 15 Dec 2021 11:16:44 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 1BFBGic9081670; Wed, 15 Dec 2021 11:16:44 GMT (envelope-from git) Date: Wed, 15 Dec 2021 11:16:44 GMT Message-Id: <202112151116.1BFBGic9081670@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Andriy Gapon Subject: git: 7dc8a0e5dff4 - main - rk_i2c: keep sending bytes until all bytes are sent List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: avg X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 7dc8a0e5dff4ad4c9c10442bef5228a91a98d5d6 Auto-Submitted: auto-generated ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1639567005; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=KHpuYR5ppa8j2KUQX4X2s20m7e7js0t8Bd7j//rTtJU=; b=bMmBevJzgurCX3O4KhgIABG0//Yar7w/7pmyuic2GYrkPP/9eH9eetf8EhZFAlnmrbRWuB z5QWM8QksROd0OpewZqsATdkF2p1OAIZwA0VihhBMJhdq/CdceYcIVXtq9O4oMOpDZaQlx Fmaeb/eMYGj9EVJiCa+Pur1VovKVTFsgzKKnNVXONAIZdywWbtkAnUa0qbB5U+eq3tidkB 8xhxcWAzQDb0vryI4FvaeogBzqKC0xR8g4w8clvC9JFE1RQWdSsBG7QkA8IgXTpQfnsuhJ E2l/W/IkLdcNp9fRSNarXOVD0calkG8CrYbNG7eMHwMwG2vaYrI3mV1m+T1hlQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1639567005; a=rsa-sha256; cv=none; b=YirQmIEo0stPMKpRIAVJ15p9e9BCizVs0MvAMr9a55XE5M6uZCLTaEV5XCFPddw3AtlOqs gSPip1BOF8WjJwXDRlwIyPIdunKefKhoZ5bUJoO3MDCx8rwOfU0t777+ssRQA2N4v+Wz+0 +dlo04LlTTx0XdUej4SjcNA8r7JPKqU2XFrBQojGksOyRMmM/s/N47it8DdcaxEbAmzmzD ONiCS6g82HE0DfcN/MXgOfMCte/jBup34lLPJUo3DY1qA+fgbB+IMHo1QZ6dtjQW/+H2RX vwhHF1/HnryigEnekg5uz5wK2DpmuANhsvNSpHumk3IHUE61pXM9NJAMUtnN/Q== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-ThisMailContainsUnwantedMimeParts: N The branch main has been updated by avg: URL: https://cgit.FreeBSD.org/src/commit/?id=7dc8a0e5dff4ad4c9c10442bef5228a91a98d5d6 commit 7dc8a0e5dff4ad4c9c10442bef5228a91a98d5d6 Author: Andriy Gapon AuthorDate: 2021-12-15 08:51:24 +0000 Commit: Andriy Gapon CommitDate: 2021-12-15 11:15:58 +0000 rk_i2c: keep sending bytes until all bytes are sent Previously the code would decalre the transfer complete after sending first 31 bytes (plus the slave address) of a larger I2C write transfer. That was tested using a large write to an EEPROM with 32-byte write page size and a 2-byte address type. Such a transaction needed to send 34 bytes, 2 bytes for an offset and 32 bytes of actual data. MFC after: 1 week --- sys/arm64/rockchip/rk_i2c.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/sys/arm64/rockchip/rk_i2c.c b/sys/arm64/rockchip/rk_i2c.c index 55cea8895c43..9db6d8739bbd 100644 --- a/sys/arm64/rockchip/rk_i2c.c +++ b/sys/arm64/rockchip/rk_i2c.c @@ -369,8 +369,14 @@ rk_i2c_intr_locked(struct rk_i2c_softc *sc) break; case STATE_WRITE: - if (sc->cnt == sc->msg->len && - !(sc->msg->flags & IIC_M_NOSTOP)) { + if (sc->cnt < sc->msg->len) { + /* Keep writing. */ + RK_I2C_WRITE(sc, RK_I2C_IEN, RK_I2C_IEN_MBTFIEN | + RK_I2C_IEN_NAKRCVIEN); + transfer_len = rk_i2c_fill_tx(sc); + RK_I2C_WRITE(sc, RK_I2C_MTXCNT, transfer_len); + break; + } else if (!(sc->msg->flags & IIC_M_NOSTOP)) { rk_i2c_send_stop(sc); break; }