From owner-freebsd-hackers Tue Feb 27 14:23:58 2001 Delivered-To: freebsd-hackers@freebsd.org Received: from peorth.iteration.net (peorth.iteration.net [208.190.180.178]) by hub.freebsd.org (Postfix) with ESMTP id BEC8137B71D for ; Tue, 27 Feb 2001 14:23:55 -0800 (PST) (envelope-from keichii@peorth.iteration.net) Received: by peorth.iteration.net (Postfix, from userid 1001) id 22FDF5954B; Tue, 27 Feb 2001 16:23:57 -0600 (CST) Date: Tue, 27 Feb 2001 16:23:57 -0600 From: "Michael C . Wu" To: Maxime Henrion Cc: hackers@freebsd.org Subject: Re: talk(1) patch to allow 8bits characters Message-ID: <20010227162357.A89484@peorth.iteration.net> Reply-To: "Michael C . Wu" References: <20010227205309.D345@nebula.cybercable.fr> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <20010227205309.D345@nebula.cybercable.fr>; from mux@qualys.com on Tue, Feb 27, 2001 at 08:53:09PM +0100 X-PGP-Fingerprint: 5025 F691 F943 8128 48A8 5025 77CE 29C5 8FA1 2E20 X-PGP-Key-ID: 0x8FA12E20 Sender: owner-freebsd-hackers@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Tue, Feb 27, 2001 at 08:53:09PM +0100, Maxime Henrion scribbled: | talk(1) uses the isprint() function to determine if a character is | printable. If it's not, it outputs '^' followed by the character without | his 8th bit. However, isprint() and friends are broken currently on | FreeBSD (at least on -STABLE), so it will never recognize an accentued | character as printable. isprint() has been broken for a long long time. Clive Lin was about to fix it. I know that we have been slacking, but please give us some time. | The attached patch remove the isprint() test so that it's possible to | write special characters. It also removes the now useless setlocale() | call and headers. Have you tried setenv LC_CTYPE=en_US.ISO-8859-1 before starting talk(1) and typing 8-bit chars? For most cases, this will work for 8-bit chars. (Yes, it is _*BADLY*_ broken.) | When locale support will be complete, I'm volunteer to re-introduce | this check if someone thinks it's really worth it. | | Could someone review this ? Sorry, the fact that you remove #include and the check for LC_CTYPE makes this patch somewhat hard to accept. However, I can accept a "talk-i18n" port that will go into the ports temporarily until we fix isprint(). Would this be acceptable for you? We can arrange to commit it as a port with you or I as the maintainer. -- +------------------------------------------------------------------+ | keichii@peorth.iteration.net | keichii@bsdconspiracy.net | | http://peorth.iteration.net/~keichii | Yes, BSD is a conspiracy. | +------------------------------------------------------------------+ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-hackers" in the body of the message