From owner-freebsd-stable@FreeBSD.ORG Wed Feb 20 15:34:42 2013 Return-Path: Delivered-To: freebsd-stable@freebsd.org Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id A889C812; Wed, 20 Feb 2013 15:34:42 +0000 (UTC) (envelope-from kpaasial@gmail.com) Received: from mail-wg0-f49.google.com (mail-wg0-f49.google.com [74.125.82.49]) by mx1.freebsd.org (Postfix) with ESMTP id F3ACEBE5; Wed, 20 Feb 2013 15:34:41 +0000 (UTC) Received: by mail-wg0-f49.google.com with SMTP id 15so6388798wgd.28 for ; Wed, 20 Feb 2013 07:34:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:x-received:in-reply-to:references:date:message-id :subject:from:to:cc:content-type; bh=1JU4SKoQSJm0buQMuS/PkhSTrp4t8sy5iHUCT4uvRmc=; b=kGCt851v+B1fcjrCXV4n9/zD9M/BLwh48w4XTefqjkjOcKbokS7+gW/bldq0iBlDU7 +Ubg6ukyEfFIkwWBhxHFqnI/0jZDq/meKbquiPh0wykVg4aQ7UjeLZagRAcrluCTIpx0 aRXmAJNI81Bue6cx1VqiUMzqVflQQ6f60epRUMjeOYIB/VdzqkbEpvrESYDT7L1oYu9Q REKkpJSWBKINMOMxORbopS4jUu0F9Y4m15ef320hUCsnogqcI6G4Pqza1A4Taft3HBJL wz78ySpzpCpX949zv5nWlh/yhIX8uw6B96pW8hx2Uuzw06AxOajEpE+a5xojPRYKngFa zPxA== MIME-Version: 1.0 X-Received: by 10.194.60.195 with SMTP id j3mr34543898wjr.33.1361374480888; Wed, 20 Feb 2013 07:34:40 -0800 (PST) Received: by 10.216.120.193 with HTTP; Wed, 20 Feb 2013 07:34:40 -0800 (PST) In-Reply-To: References: <7A12B6B7-BE3F-4E0A-99C5-61348CA7E028@lassitu.de> Date: Wed, 20 Feb 2013 17:34:40 +0200 Message-ID: Subject: Re: stable/9 r245439 breaks security/pam_ssh_agent_auth on stable/9 (WAS: CLANG 3.2 breaks security/pam_ssh_agent_auth on stable/9) From: Kimmo Paasiala To: Stefan Bethke Content-Type: text/plain; charset=UTF-8 Cc: freebsd-stable@freebsd.org, freebsd-ports@freebsd.org, "miwi@freebsd.org" X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Feb 2013 15:34:42 -0000 On Wed, Feb 6, 2013 at 12:28 AM, Stefan Bethke wrote: > > Am 05.02.2013 um 23:06 schrieb Stefan Bethke : > >> Am 05.02.2013 um 19:09 schrieb Kimmo Paasiala : >> >>> On Tue, Feb 5, 2013 at 12:36 AM, Kimmo Paasiala wrote: >>>> On Sun, Feb 3, 2013 at 7:22 PM, Chris Rees wrote: >>>>> On 3 February 2013 17:15, Stefan Bethke wrote: >>>>>> >>>>>> Am 03.02.2013 um 10:57 schrieb Chris Rees : >>>>>> >>>>>>> On 3 February 2013 03:55, Kimmo Paasiala wrote: >>>>>>>> >>>>>>>> There is no PR yet with my fix and therefor no commit to ports tree >>>>>>>> that would fix the problem. I'll file a PR soon (TM). >>>>>>> >>>>>>> The problem was in base, and is fixed there. >>>>>> >>>>>> Huh? With -current r246283, I still get a segfault from sudo unless I have Kimmo's patch. >>>>>> >>>>>> Is there some confusion about which problem is addressed by Kimmo's patch? >>>>>> >>>>> >>>>> Hm, perhaps it might be necessary then. >>>>> >>>>> Kimmo, please would you submit the patch you had as a PR? I'm sure >>>>> Wesley would appreciate the hint. >>>>> >>>>> Chris >>>> >>>> I'll file a PR when I have recovered from a nasty flu. Right now I'm >>>> not fit for thinking... >>>> >>>> I changed the title of this thread to a better one. >>>> >>>> -Kimmo >>> >>> It looks like the port was updated just recently to a new version that >>> has its own problems that are no longer related strnvis(3). I'll have >>> to give up for now. >>> >>> (freebsd-ports added to cc:) >> >> I can confirm that with the new port version on a two day old current, the module doesn't work: >> $ uname -a >> FreeBSD freebsd-current.lassitu.de 10.0-CURRENT FreeBSD 10.0-CURRENT #0 r246283: Sun Feb 3 16:55:16 CET 2013 root@freebsd-current.lassitu.de:/usr/obj/usr/src/sys/GENERIC amd64 >> $ pkg info|grep pam >> pam_ssh_agent_auth-0.9.4 PAM module which permits authentication via ssh-agent >> $ sudo ls >> sudo: unable to initialize PAM: No error: 0 >> >> If I downgrade to the previous port version (and apply Kimmo's patch), it's working properly. > > > Here's a slightly different error message on 9-stable: > $ uname -a > FreeBSD diesel.lassitu.de 9.1-STABLE FreeBSD 9.1-STABLE #7 r245996: Sun Jan 27 22:36:05 CET 2013 root@diesel.lassitu.de:/usr/obj/usr/src/sys/DIESEL amd64 > stb@diesel:~$ sudo ls > sudo: unable to initialize PAM: No such file or directory > > > Stefan > > -- > Stefan Bethke Fon +49 151 14070811 > > > Latest version pam_ssh_agent_auth-0.9.4_1 seems to finally work without any extra patches when built on a 9.1-RELEASE system. -Kimmo