From nobody Wed Aug 16 11:57:32 2023 X-Original-To: bugs@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4RQmph60WRz4qZsj for ; Wed, 16 Aug 2023 11:57:32 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4RQmph4h25z4QjT for ; Wed, 16 Aug 2023 11:57:32 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1692187052; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=prL/wSSxdh0UJKJTXZlyFQWfqyHCFxJnc02/jdBJd5E=; b=qqYNKZwNxEI8MSEdDMKZ1/YlE3aIlwmNGmDQyyQWP6Ovm15fRXoB4SSmvBEdMrpWTKkek9 vC2Wj5P653xMf6y0vehvITgvyA6Bz0eMrUL5rG4cai2BhrT/qGi9hjIT8Sdr6kZr4LmO/f IXhA1L5DEEQ5c0nOJW0nxmrlfKH7KTcqtvEWkFbYy44Q18hVcr8MDiVjCCa4271lwZwvL3 v927KHS7v8VBIfGRaWMFZfE/s7xwjAo2l2/2d2SKLLI+rXIV/zfdg3jW0/xonee9vwZcOw UmeNQvGjocx4kmzMH571IttviXWQnEbJOue+4yFxsv8svwacWBQj+DkCfjLV6w== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1692187052; a=rsa-sha256; cv=none; b=q724sDNfYdBYDbCUyQ5/buLokS3K52vdytKlU037GjVoY1mN/sY0BgsRhUvN3kJivu6Ddo yjfRdrDQN4WovzPxvTgch0VebfrjmVQjLTi1Y6bL2Va4DUBv86dOIMVpj7y6l4sTnN3mPw as4pOVHkZCvBI4jf8fOZ6XhLJ4610012qqeuqIQnRQ8/p0GuUVcrqr8bACCl7Ps2kzECWU 50+2V50O5Od2n8qOUr/sj5UWFh/ceB2hxWiK2532U2MQnN0BJ+M6wCuqD9PqKY9NnOPC7X Y8llqGEKnnAGOxQDsMpATWrXT2EMJmuW0mUSAEIe2ubXKMhCBKCyXPnTFtbPCA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4RQmph3kWtzrMs for ; Wed, 16 Aug 2023 11:57:32 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 37GBvWN8000310 for ; Wed, 16 Aug 2023 11:57:32 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 37GBvWFu000309 for bugs@FreeBSD.org; Wed, 16 Aug 2023 11:57:32 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 273148] [PATCH] scripted installs are unable to verify checksums for fetched dists Date: Wed, 16 Aug 2023 11:57:32 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: bin X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: lars@oddbit.com X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Bug reports List-Archive: https://lists.freebsd.org/archives/freebsd-bugs List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-bugs@freebsd.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D273148 --- Comment #3 from Lars Kellogg-Stedman --- > Have you read the commit message... Of course...and then I read the code, which is logically incorrect, syntactically incorrect, obviously never tested, and breaks a major existing piece of functionality. It should never have been accepted in the first pla= ce. The commit also looks like only a partial attempt at a solution, because it doesn't touch the identical code in the "auto" script (nor the several additional places in "auto" that perform the same fd manipulation). I think reverting the original commit is absolutely the best course of acti= on because it restores the ability to perform fully automated installs. If the commit was solving a real problem, we can take the time to develop a more effective solution once we have un-broken this critical feature. --=20 You are receiving this mail because: You are the assignee for the bug.=