Date: Sun, 16 Sep 2018 22:59:28 +0200 From: =?UTF-8?Q?Ren=c3=a9_Ladan?= <rene@freebsd.org> To: Mathieu Arnold <mat@FreeBSD.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r479894 - head/textproc/pootle Message-ID: <635d0671-2792-c5cb-bf87-bfb022731510@freebsd.org> In-Reply-To: <20180916201342.unhwsto2b62u4lhj@atuin.in.mat.cc> References: <201809161403.w8GE3TYD059511@repo.freebsd.org> <20180916201342.unhwsto2b62u4lhj@atuin.in.mat.cc>
next in thread | previous in thread | raw e-mail | index | archive | help
On 16-09-18 22:13, Mathieu Arnold wrote: > On Sun, Sep 16, 2018 at 02:03:29PM +0000, Rene Ladan wrote: >> Author: rene >> Date: Sun Sep 16 14:03:28 2018 >> New Revision: 479894 >> URL: https://svnweb.freebsd.org/changeset/ports/479894 >> >> Log: >> textproc/pootle: cleanup option handling: >> =20 >> - use option helpers >> - remove stale SUBVERSION option >> - use SINGLE option to choose between MySQL and PostgresSQL > Why use SINGLE ? The options do not seem to be incompatible, nor > required. OPTIONS_GROUP would probably be better. (OPTIONS_MULTI if on= e > is required.) From http://docs.translatehouse.org/projects/pootle/en/latest/server/installat= ion.html : For a production deployment we *strongly* recommend that you set up the following: * Install optional optimization packages <http://docs.translatehouse.org/projects/pootle/en/latest/server/opti= mization.html#optimization-optional-software> * Use either a MySQL <http://docs.translatehouse.org/projects/pootle/en/latest/server/mysq= l_installation.html#mysql-installation> or PostgreSQL <http://docs.translatehouse.org/projects/pootle/en/latest/server/post= gresql_installation.html#postgresql-installation> database. So it database dependency is not strictly needed, but recommended. Anyway, I'll see if I can update this port to 2.8.2 soon now that the Django dependencies do not conflict with each other any longer. The new port builds fine, now to see if it does something useful. Ren=E9 >> Modified: >> head/textproc/pootle/Makefile >> >> Modified: head/textproc/pootle/Makefile >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D >> --- head/textproc/pootle/Makefile Sun Sep 16 13:25:54 2018 (r479893) >> +++ head/textproc/pootle/Makefile Sun Sep 16 14:03:28 2018 (r479894) >> @@ -44,7 +44,10 @@ SUB_LIST+=3D PYTHON_CMD=3D"${PYTHON_CMD}" >> =20 >> PORTDOCS=3D CREDITS INSTALL LICENSE >> =20 >> -OPTIONS_DEFINE=3D DOCS LDAP MEMCACHED MYSQL PGSQL >> +OPTIONS_DEFINE=3D DOCS LDAP MEMCACHED >> +OPTIONS_SINGLE=3D DB >> +DB_DESC=3D Database backend >> +OPTIONS_SINGLE_DB=3DMYSQL PGSQL >> OPTIONS_DEFAULT=3DMEMCACHED MYSQL >> =20 >> MEMCACHED_DESC=3D Use memcached to improve performance >> @@ -54,17 +57,11 @@ LDAP_RUN_DEPENDS=3D ${PYTHON_PKGNAMEPREFIX}ldap2>0= :devel >> MEMCACHED_LIB_DEPENDS=3D libmemcached.so:databases/libmemcached >> MEMCACHED_RUN_DEPENDS=3D ${PYTHON_PKGNAMEPREFIX}python-memcached>=3D1= =2E45:databases/py-python-memcached@${PY_FLAVOR} >> =20 >> +MYSQL_USES=3D mysql:client >> MYSQL_RUN_DEPENDS=3D ${PYTHON_PKGNAMEPREFIX}MySQLdb>0:databases/py-My= SQLdb@${PY_FLAVOR} >> =20 >> PGSQL_RUN_DEPENDS=3D ${PYTHON_PKGNAMEPREFIX}psycopg2>0:databases/py-p= sycopg2@${PY_FLAVOR} >> =20 >> -SUBVERSION_RUN_DEPENDS=3D svn:devel/subversion >> - >> -.include <bsd.port.pre.mk> >> -.if ${PORT_OPTIONS:MMYSQL} >> -USES+=3D mysql:client >> -.endif >> - >> pre-configure: >> @${REINPLACE_CMD} -e "s/,<0.11.2//g" \ >> -e "s/,<0.8//g" \ >> @@ -78,4 +75,4 @@ post-install-DOCS-on: >> ${INSTALL_DATA} ${WRKSRC}/${docs} ${STAGEDIR}/${DOCSDIR} >> .endfor >> =20 >> -.include <bsd.port.post.mk> >> +.include <bsd.port.mk> >> >>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?635d0671-2792-c5cb-bf87-bfb022731510>