Date: Thu, 9 Dec 2010 12:50:16 +0100 From: Pawel Jakub Dawidek <pjd@FreeBSD.org> To: Kostik Belousov <kostikbel@gmail.com> Cc: Kirk McKusick <mckusick@mckusick.com>, freebsd-fs@freebsd.org, Oliver Fromme <olli@lurza.secnetix.de> Subject: Re: TRIM support for UFS? Message-ID: <20101209115016.GB1745@garage.freebsd.pl> In-Reply-To: <20101209103411.GL33073@deviant.kiev.zoral.com.ua> References: <20101208225352.GK33073@deviant.kiev.zoral.com.ua> <201012082356.oB8NuxwX040914@chez.mckusick.com> <20101209103411.GL33073@deviant.kiev.zoral.com.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
--rS8CxjVDS/+yyDmU
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Thu, Dec 09, 2010 at 12:34:11PM +0200, Kostik Belousov wrote:
> I still think that TRIM should be opt-in, at least for the first time.
> Below is the BIO_GETATTR change integrated.
>=20
> Now, both FS_TRIM should be set and device shall report the
> GEOM::candelete attribute as true to have BIO_DELETE issued. geom_disk
> and md(4) report GEOM::candelete. Also, I updated tunefs(8) manpage,
> missed in the previous version.
[...]
> --- a/sbin/tunefs/tunefs.c
> +++ b/sbin/tunefs/tunefs.c
[...]
> @@ -1035,6 +1069,8 @@ printfs(void)
> (sblock.fs_flags & FS_SUJ)? "enabled" : "disabled");
> warnx("gjournal: (-J) %s",
> (sblock.fs_flags & FS_GJOURNAL)? "enabled" : "disabled");
> + warnx("trim: (-p) %s",=20
s/-p/-t/
Other than that looks nice and clean.
--=20
Pawel Jakub Dawidek http://www.wheelsystems.com
pjd@FreeBSD.org http://www.FreeBSD.org
FreeBSD committer Am I Evil? Yes, I Am!
--rS8CxjVDS/+yyDmU
Content-Type: application/pgp-signature
Content-Disposition: inline
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.14 (FreeBSD)
iEYEARECAAYFAk0AwngACgkQForvXbEpPzSWYACgjK/Fte2usUZq27amqDrSun9X
9lUAn1Xa9dvVXhG/gagkUrKl6HVVwgP9
=wUsX
-----END PGP SIGNATURE-----
--rS8CxjVDS/+yyDmU--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20101209115016.GB1745>