From owner-cvs-src@FreeBSD.ORG Sun Dec 18 18:14:47 2005 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 301F116A41F; Sun, 18 Dec 2005 18:14:47 +0000 (GMT) (envelope-from nate@root.org) Received: from ylpvm12.prodigy.net (ylpvm12-ext.prodigy.net [207.115.57.43]) by mx1.FreeBSD.org (Postfix) with ESMTP id A730343D58; Sun, 18 Dec 2005 18:14:46 +0000 (GMT) (envelope-from nate@root.org) Received: from pimout5-ext.prodigy.net (pimout5-int.prodigy.net [207.115.4.21]) by ylpvm12.prodigy.net (8.12.10 outbound/8.12.10) with ESMTP id jBIIEiKI002110; Sun, 18 Dec 2005 13:14:45 -0500 X-ORBL: [71.139.30.140] Received: from [10.0.0.115] (ppp-71-139-30-140.dsl.snfc21.pacbell.net [71.139.30.140]) by pimout5-ext.prodigy.net (8.13.4 outbound domainkey aix/8.13.4) with ESMTP id jBIIEhHN079006; Sun, 18 Dec 2005 13:14:44 -0500 Message-ID: <43A5A70A.4000508@root.org> Date: Sun, 18 Dec 2005 10:14:34 -0800 From: Nate Lawson User-Agent: Mozilla Thunderbird 1.0.6 (X11/20050723) X-Accept-Language: en-us, en MIME-Version: 1.0 To: John Baldwin References: <200512170357.jBH3vAhh030893@repoman.freebsd.org> <200512171445.04475.jhb@freebsd.org> In-Reply-To: <200512171445.04475.jhb@freebsd.org> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/sys ktr.h src/sys/kern kern_clock.c kern_switch.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 18 Dec 2005 18:14:47 -0000 John Baldwin wrote: > On Friday 16 December 2005 10:57 pm, Nate Lawson wrote: > >>njl 2005-12-17 03:57:10 UTC >> >> FreeBSD src repository >> >> Modified files: >> sys/sys ktr.h >> sys/kern kern_clock.c kern_switch.c >> Log: >> Clean up unused or poorly utilized KTR values. Remove KTR_FS, KTR_KGDB, >> and KTR_IO as they were never used. Remove KTR_CLK since it was only >> used for hardclock firing and use KTR_INTR there instead. Remove >> KTR_CRITICAL since it was only used for crit enter/exit and use >> KTR_CONTENTION instead. > > > Actually, I thought I had mentioned that KTR_CRITICAL should stay as it is > (well, and the larger thought about doing away with the entire bitmask > concept which no one responded to). critical_enter/exit are not related in > the least to KTR_CONTENTION which is used for MUTEX_PROFILING, nor do they > have anything at all to do with contention of any sort. If you must stick > them somewhere, put them in KTR_SCHED instead. I think scottl@ recently > added support to schedgraph for those traces anyway (though I'm not sure if > they are in his local tree or CVS). Ah, I misread your email. I see now what you said. > The hardclock trace can probably just be axed entirely as it isn't all that > useful. Ok, done. -- Nate