From owner-p4-projects@FreeBSD.ORG  Sun Sep 16 12:47:29 2007
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 4259816A41A; Sun, 16 Sep 2007 12:47:29 +0000 (UTC)
Delivered-To: perforce@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 0BBE516A417
	for <perforce@FreeBSD.org>; Sun, 16 Sep 2007 12:47:29 +0000 (UTC)
	(envelope-from gonzo@FreeBSD.org)
Received: from repoman.freebsd.org (repoman.freebsd.org
	[IPv6:2001:4f8:fff6::29])
	by mx1.freebsd.org (Postfix) with ESMTP id E7E5A13C45A
	for <perforce@FreeBSD.org>; Sun, 16 Sep 2007 12:47:28 +0000 (UTC)
	(envelope-from gonzo@FreeBSD.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id l8GClSET019236
	for <perforce@FreeBSD.org>; Sun, 16 Sep 2007 12:47:28 GMT
	(envelope-from gonzo@FreeBSD.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.14.1/8.14.1/Submit) id l8GClSU0019233
	for perforce@freebsd.org; Sun, 16 Sep 2007 12:47:28 GMT
	(envelope-from gonzo@FreeBSD.org)
Date: Sun, 16 Sep 2007 12:47:28 GMT
Message-Id: <200709161247.l8GClSU0019233@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	gonzo@FreeBSD.org using -f
From: Oleksandr Tymoshenko <gonzo@FreeBSD.org>
To: Perforce Change Reviews <perforce@FreeBSD.org>
Cc: 
Subject: PERFORCE change 126469 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 16 Sep 2007 12:47:29 -0000

http://perforce.freebsd.org/chv.cgi?CH=126469

Change 126469 by gonzo@gonzo_jeeves on 2007/09/16 12:47:23

	o Remove printf from tick_init_params since UART code may use
	    DELAY(9) so tick_init_params should be called before cninit.

Affected files ...

.. //depot/projects/mips2/src/sys/mips/mips/tick.c#18 edit

Differences ...

==== //depot/projects/mips2/src/sys/mips/mips/tick.c#18 (text+ko) ====

@@ -83,6 +83,10 @@
 tick_init_params(uint64_t platform_counter_freq, int double_count)
 {
 
+	/* 
+	 * XXX: Do not use printf here: uart code 8250 may use DELAY so
+	 * this function should  be called before cninit. 
+	 */
 	counter_freq = platform_counter_freq;
 
 	counts_per_hz = counter_freq / hz;
@@ -97,13 +101,13 @@
 		counts_per_usec /= 2;
 	}
 
-	printf("MIPS32 clock: %ju Hz\n", (intmax_t)counter_freq);
 	set_cputicker(tick_ticker, counter_freq, 1);
 }
 
 void tick_init(void)
 {
 
+	printf("MIPS32 clock: %ju Hz\n", (intmax_t)counter_freq);
 	if (counter_freq != 0 && !counter_is_broken) {
 		counter_timecounter.tc_frequency = counter_freq;
 		tc_init(&counter_timecounter);