From owner-freebsd-net@freebsd.org Fri Jan 13 22:27:55 2017 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 2E986CAEC92; Fri, 13 Jan 2017 22:27:55 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pf0-x241.google.com (mail-pf0-x241.google.com [IPv6:2607:f8b0:400e:c00::241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id EDDA41E93; Fri, 13 Jan 2017 22:27:54 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-pf0-x241.google.com with SMTP id y143so10033940pfb.1; Fri, 13 Jan 2017 14:27:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:mime-version:from:in-reply-to:date:cc:message-id:references :to; bh=xSH0RWQ0Sc5pYUS471PVPmWO761Qjyq9ND9fXOyzgHc=; b=cpoeN0s3FQd0jii2PoZvChtw97kCVjN60A/LE1Ib7lo6sC/EvegWILBldsTR++J5F8 entDwPY/xZHKj0oJeenuEUDoP+MuNBOZSjz2vsmq7D3/wSf8c6KQisHK/2JmDvkS/+jU x3RMyQF0yGpTRSBJGlJD0CbYWVLfrXvVUBKSyCFg4MV816GHjQZkPHDnFql7gE/T0eqE hKZ9j3dX2WbkQnOue66y4xYuR7kWTQl9VJdtmbrAd4lhZ3WjY5UetxQKo4j6RvzkMf/F +W/uUpdiEgRE7hXuA8QSOU1qDvQwkw+ZjTU7AKUjAzAsoZF7QwSD62EFzokuGkgZ8wYA GM5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:mime-version:from:in-reply-to:date:cc :message-id:references:to; bh=xSH0RWQ0Sc5pYUS471PVPmWO761Qjyq9ND9fXOyzgHc=; b=udCQW0hvZ6dOkY12Q4Ufuwk4/AzdK7jAxSDyvoVHTt9Hy7hEFAq41YfwBBoNOV+mXS icTNuJZ6pFVQ8+22DCvieXSEYvkN27tOVIgU5DbUK4ORQDcWB9FWdSWCkuNTUCXIuo4Q 0tjpeZCg83PC2WJhzm+t0fnhJElSruDqeV7edyVwSXXPLegUvpRMqN0lmmNStQLdNBdr Kai1Z6iylIBleihqbQSavzxXjSAvGza7AbfWSfENoXi1FkkhmkpbYZbFKJuFaXyPt1b/ fiJF/i621aXw7jveZLCrJ4WRLRDS03PMspWF2lzvG1YPzVE11jHu68/3BqQACasn5YGB 5NAw== X-Gm-Message-State: AIkVDXI/FhOg1vlyx6bMM/4nYzAHqW2mdby/cLEhZjdWICpuUan3TJkvaADiVGEmTyIPpg== X-Received: by 10.84.233.193 with SMTP id m1mr32897862pln.126.1484346474334; Fri, 13 Jan 2017 14:27:54 -0800 (PST) Received: from pinklady.local (c-73-19-52-228.hsd1.wa.comcast.net. [73.19.52.228]) by smtp.gmail.com with ESMTPSA id x8sm31655517pge.15.2017.01.13.14.27.53 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 13 Jan 2017 14:27:53 -0800 (PST) Subject: Re: powerpc.LINT* broken in netmap(4) Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) Content-Type: multipart/signed; boundary="Apple-Mail=_37801E61-DF34-4A8A-ACD3-5B34951F261D"; protocol="application/pgp-signature"; micalg=pgp-sha512 X-Pgp-Agent: GPGMail From: "Ngie Cooper (yaneurabeya)" In-Reply-To: Date: Fri, 13 Jan 2017 14:27:52 -0800 Cc: FreeBSD CURRENT , Luigi Rizzo Message-Id: <49F36EE5-D3BD-420A-9F16-2219C7C83AC8@gmail.com> References: To: freebsd-net@FreeBSD.org X-Mailer: Apple Mail (2.3124) X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Jan 2017 22:27:55 -0000 --Apple-Mail=_37801E61-DF34-4A8A-ACD3-5B34951F261D Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On Jan 13, 2017, at 02:22, Ngie Cooper (yaneurabeya) = wrote: >=20 > Hi, > I spotted these compilation errors on universe12a.freebsd.org = for both powerpc.LINT and powerpc.LINT64: >=20 > cc1: warnings being treated as errors > /scratch/tmp/ngie/svn/sys/dev/netmap/netmap_generic.c: In function = 'generic_set_tx_event': > /scratch/tmp/ngie/svn/sys/dev/netmap/netmap_generic.c:765: warning: = the address of 'generic_mbuf_destructor' will always evaluate as 'true' = [-Waddress] > --- netmap_generic.o --- > *** [netmap_generic.o] Error code 1 >=20 > I haven=E2=80=99t yet dug into why this only surfaces on = powerpc, yet=E2=80=A6 (CC -powerpc; BCC +powerpc) Hi, sparc64 has the same issue as powerpc*, so I suspect that gcc is = flagging this as an issue. Thanks, -Ngie PS. Sidenote: why was the SET_MBUF_DESTRUCTOR macro added, but not used = in nm_os_get_mbuf ? --Apple-Mail=_37801E61-DF34-4A8A-ACD3-5B34951F261D Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJYeVRoAAoJEPWDqSZpMIYVzf0QAMZ0TfNkcUpB+9Lksy3BNTSO tZZnO3gI8VpZ+XIBf/tlaoW7sKkwzVtficd1kvqz8iy4HCfapYU5Mf9BjowrQzY+ kPpUE+kckOwIYjS5AkQQHeEHKsr4F99O9Orj7DZBBWP4+9yeqDl48tnNw0N82zFF 4F3FDs9I/tFLyXNOX6K1gs4cJfUah1PwktFFIAXLXpAiqHx+TyxEgGFn0TJKmsVD TcKpW50MNFlc2lJzxKZeVVXCt2GwdjeautkKX+qVt+kbno4J+uJN0lTsJPBp25Tg M3rmgK8bBl7DL0DfreTwsVyQP4Czy9L0FwKkS8AkjPjLa0PZXDUsHJaeR9ITaAFD Tyyh44oIxcTashT20Yp590A0E0EOhuIkt18aEOAKgVuS8KKLl0GnsNsdxv1BtfSD 5H/PSjV7RdfijrzuDH9ChAs/7Z4GeL9MsBQIoNGz3lZ6dRRYq+b5WyPLTsf/ldpI mLm1bNyMuxPoYO+U7lYfK98qQS5fHKn6pO9vzdP4qu6qRfgx19VzfAC3hvzFNPrr tDeF13L8t5J5549rIXVyMEEUvSCQFiDqhwNrN5LIZBVzY3YP23tKM4WqaufAwLTC VctYhfTOCYxv74euyH39iGhW+4ohBtteJ6cV4QVf9DGFZ0+r3jR66vCbB10hBqRW 3845E6ngPZ0o1aGJbpck =8BD3 -----END PGP SIGNATURE----- --Apple-Mail=_37801E61-DF34-4A8A-ACD3-5B34951F261D--