From owner-freebsd-fs@FreeBSD.ORG Mon Jan 3 04:14:51 2011 Return-Path: Delivered-To: freebsd-fs@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 2A5B6106566B for ; Mon, 3 Jan 2011 04:14:51 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: from mail2.fluidhosting.com (mx22.fluidhosting.com [204.14.89.5]) by mx1.freebsd.org (Postfix) with ESMTP id AFC698FC18 for ; Mon, 3 Jan 2011 04:14:50 +0000 (UTC) Received: (qmail 22724 invoked by uid 399); 3 Jan 2011 04:14:49 -0000 Received: from localhost (HELO doug-optiplex.ka9q.net) (dougb@dougbarton.us@127.0.0.1) by localhost with ESMTPAM; 3 Jan 2011 04:14:49 -0000 X-Originating-IP: 127.0.0.1 X-Sender: dougb@dougbarton.us Message-ID: <4D214D38.1000209@FreeBSD.org> Date: Sun, 02 Jan 2011 20:14:48 -0800 From: Doug Barton Organization: http://SupersetSolutions.com/ User-Agent: Mozilla/5.0 (X11; U; FreeBSD amd64; en-US; rv:1.9.2.13) Gecko/20101210 Thunderbird/3.1.7 MIME-Version: 1.0 To: giffunip@tutopia.com References: <352778.3837.qm@web113503.mail.gq1.yahoo.com> In-Reply-To: <352778.3837.qm@web113503.mail.gq1.yahoo.com> X-Enigmail-Version: 1.1.2 OpenPGP: id=1A1ABC84 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: freebsd-fs@FreeBSD.org Subject: Re: ext2fs: PR 153584, prealloc, etc. X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 03 Jan 2011 04:14:51 -0000 On 01/02/2011 19:21, Pedro F. Giffuni wrote: > Thanks for the bug report. This will be very easy to fix and I don't > know why I didn't see it here. but for now use this simpler patch. Ok, the simpler patch worked, but then I see that you sent a follow-up to the PR with a new patch that supposedly fixes my issue. I definitely appreciate your fast attention to this, but I've already applied your smaller patch and rebooted, and I have stuff of my own to work on. :) The good news is that patch-dbe applied over the older pre-allocation patch just fine. >> Any chance you 2 could work together to come up with 1 patch that >> has the best of both worlds, and actually compiles on HEAD? It >> would also be really useful if the resultant patch was created >> using 'svn diff' as it would be a lot easier for those of us who >> are interested in testing this to do so, not to mention actually >> getting it committed. >> > > We have been working together with Zheng Liu, who did the > preallocation patch, but I believe these fixes should come first. That's fine, I appreciate that this is getting attention. Doug -- Nothin' ever doesn't change, but nothin' changes much. -- OK Go Breadth of IT experience, and depth of knowledge in the DNS. Yours for the right price. :) http://SupersetSolutions.com/