From owner-svn-ports-head@FreeBSD.ORG Sun Oct 20 00:50:24 2013 Return-Path: Delivered-To: svn-ports-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 65F2855F; Sun, 20 Oct 2013 00:50:24 +0000 (UTC) (envelope-from baptiste.daroussin@gmail.com) Received: from mail-we0-x233.google.com (mail-we0-x233.google.com [IPv6:2a00:1450:400c:c03::233]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 7CDDE2AE7; Sun, 20 Oct 2013 00:50:23 +0000 (UTC) Received: by mail-we0-f179.google.com with SMTP id w61so5079377wes.38 for ; Sat, 19 Oct 2013 17:50:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=KdKCdxYjLAkpHAaQG+0zbygImn4/wVG7sRRAdB5/npk=; b=Rl0Vs1NImC+nDC3m0KwrkZtwKiIDnujzL8HjF5U+prjVnrRn08Kg3+TXywxf7BLDpc n3wmPI8Qab/HEZydzUr48x91SKlcK5BWSbIP110poVpx5v/YWWBgy3m4lW/R9qiHH9Qk rwu3xS4CbyOpsszor3olV/XgmKrkrnncWzvaCOXZE5Z+Oi6/5IgJsTO24ufn9Ky5tPPK l8BeHEuzRIWA9FDpP9ldevPM7wi/IbsV44DFZk7LtGDDYugwDqdN5k2fIirRNiVZ50qk UIL3eS6SqvsgXWYIk6eXgCOxE82hc33/vjJIGu4xQOK+V0x527vHXepX11oQA1D/j+dq sjGA== X-Received: by 10.180.188.49 with SMTP id fx17mr4395422wic.33.1382230221773; Sat, 19 Oct 2013 17:50:21 -0700 (PDT) Received: from ithaqua.etoilebsd.net (ithaqua.etoilebsd.net. [37.59.37.188]) by mx.google.com with ESMTPSA id ma3sm17713355wic.1.2013.10.19.17.50.20 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Sat, 19 Oct 2013 17:50:21 -0700 (PDT) Sender: Baptiste Daroussin Date: Sun, 20 Oct 2013 02:50:18 +0200 From: Baptiste Daroussin To: Alexey Dokuchaev Subject: Re: svn commit: r330906 - head/multimedia/vcdpad Message-ID: <20131020005018.GG57066@ithaqua.etoilebsd.net> References: <201310191630.r9JGUXZJ049165@svn.freebsd.org> <20131019163648.GA61417@FreeBSD.org> <20131019163946.GF57066@ithaqua.etoilebsd.net> <20131019165702.GA64069@FreeBSD.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="Cp3Cp8fzgozWLBWL" Content-Disposition: inline In-Reply-To: <20131019165702.GA64069@FreeBSD.org> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 20 Oct 2013 00:50:24 -0000 --Cp3Cp8fzgozWLBWL Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Oct 19, 2013 at 04:57:02PM +0000, Alexey Dokuchaev wrote: > On Sat, Oct 19, 2013 at 06:39:46PM +0200, Baptiste Daroussin wrote: > > On Sat, Oct 19, 2013 at 04:36:48PM +0000, Alexey Dokuchaev wrote: > > > On Sat, Oct 19, 2013 at 04:30:33PM +0000, Baptiste Daroussin wrote: > > > > New Revision: 330906 > > > > URL: http://svnweb.freebsd.org/changeset/ports/330906 > > > >=20 > > > > [...] > > > > +post-install: > > > > + ${STRIP_CMD} ${STAGEDIR}${PREFIX}/bin/${PORTNAME} > > >=20 > > > How do you know if installed binaries should be post-stripped? Is th= ere > > > automated check involved? What if, for any reason, binary indeed mus= t be > > > installed unstripped? > >=20 > > make stage warns about unstripped binaries if you have DEVELOPERS=3DYES= in your > > make.conf, >=20 > I suppose it should read DEVELOPER, not DEVELOPER_S_, right? yes >=20 > > if you need the binaries unstripped then just do not strip them, those = works > > stripped properly, btw STRIP_CMD respects WITH_DEBUG. >=20 > > I understand; I was worrying about rare cases when stripping the binary (= not > for debugging) actually renders it unusable in certain circumstances. Do= n't > get me wrong, I also prefer to have installed binaries normally stripped,= but > I vaguely recall there were cases, albeit rarely seen, when upstream actu= ally > intended unstripped installs, for a reason. I just hope that these sorts= of > automatic suggestions would not result in massive commits that would resu= lt > in broken installations. From what I see how easily folks follow portlin= t's > sometimes misguided advice, it could become problem. > >=20 I second that pessimistic thought :) That is why it is a warning nor an error, any advice on better warning message to avoid this case to happen would be appreciated :) regards, Bapt --Cp3Cp8fzgozWLBWL Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) iEYEARECAAYFAlJjKMoACgkQ8kTtMUmk6Ewv0wCgpSgs/ExOY3gMIJNse10kvDle pxcAn05pEt3wjgaNc9uQtFIx1tV9w3DN =l4cW -----END PGP SIGNATURE----- --Cp3Cp8fzgozWLBWL--