From owner-freebsd-ports-bugs@FreeBSD.ORG Fri Apr 14 18:40:13 2006 Return-Path: X-Original-To: freebsd-ports-bugs@hub.freebsd.org Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id DAA8016A403 for ; Fri, 14 Apr 2006 18:40:13 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 57DF543D45 for ; Fri, 14 Apr 2006 18:40:13 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id k3EIeDVa074073 for ; Fri, 14 Apr 2006 18:40:13 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.4/8.13.4/Submit) id k3EIeD0S074067; Fri, 14 Apr 2006 18:40:13 GMT (envelope-from gnats) Resent-Date: Fri, 14 Apr 2006 18:40:13 GMT Resent-Message-Id: <200604141840.k3EIeD0S074067@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Friedrich Volkmann Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4054016A400 for ; Fri, 14 Apr 2006 18:39:46 +0000 (UTC) (envelope-from root@83-64-202-138.dynamic.adsl-line.inode.at) Received: from 83-64-202-138.dynamic.adsl-line.inode.at (62-99-226-42.static.adsl-line.inode.at [62.99.226.42]) by mx1.FreeBSD.org (Postfix) with ESMTP id BCF0B43D45 for ; Fri, 14 Apr 2006 18:39:45 +0000 (GMT) (envelope-from root@83-64-202-138.dynamic.adsl-line.inode.at) Received: by 83-64-202-138.dynamic.adsl-line.inode.at (Postfix, from userid 0) id B74E915220; Fri, 14 Apr 2006 20:42:17 +0200 (CEST) Message-Id: <20060414184217.B74E915220@83-64-202-138.dynamic.adsl-line.inode.at> Date: Fri, 14 Apr 2006 20:42:17 +0200 (CEST) From: Friedrich Volkmann To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: Subject: ports/95759: [patch] parallel port builds broken X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 Apr 2006 18:40:14 -0000 >Number: 95759 >Category: ports >Synopsis: [patch] parallel port builds broken >Confidential: no >Severity: non-critical >Priority: medium >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Fri Apr 14 18:40:12 GMT 2006 >Closed-Date: >Last-Modified: >Originator: Friedrich Volkmann >Release: FreeBSD 6.1-PRERELEASE i386 >Organization: >Environment: System: FreeBSD 83-64-202-138.dynamic.adsl-line.inode.at 6.1-PRERELEASE FreeBSD 6.1-PRERELEASE #0: Tue Apr 4 20:57:01 CEST 2006 root@62-99-193-64.static.adsl-line.inode.at:/usr/obj/usr/src/sys/CU03 i386 >Description: Installing ports with MAKEFLAGS=-j2 or higher doesn't work: 1) Some targets are made parallelly where they shouldn't. E.g. the package is registered before check-already-installed. 2) "make install" without a preceding "make configure" or "make build" terminates between run-depends and lib-depends. "make -dm install" reports: "Examining lib-depends...predecessor run-depends not made yet." As a part of _INSTALL_SEQ, lib-depends is forced to be made after build, ..., and run-depends. But as a part of _CONFIGURE_SEQ, lib-depends must be made before build. Maybe lib-depends could just be removed from _INSTALL_SEQ, as it is already checked at configure time. However, the patch follows a soft approach, keeping the double check. >How-To-Repeat: cd /usr/ports/devel/libtool15 # or any other port make clean MAKEFLAGS=-j2 make install >Fix: diff -u3 /usr/ports/Mk/bsd.port.mk.orig /usr/ports/Mk/bsd.port.mk --- /usr/ports/Mk/bsd.port.mk.orig Thu Feb 23 16:37:20 2006 +++ /usr/ports/Mk/bsd.port.mk Thu Apr 13 21:31:47 2006 @@ -3774,7 +3774,7 @@ post-build post-build-script _INSTALL_DEP= build _INSTALL_SEQ= install-message check-conflicts \ - run-depends lib-depends apply-slist pre-install \ + run-depends lib-depends2 apply-slist pre-install \ pre-install-script generate-plist check-already-installed _INSTALL_SUSEQ= check-umask install-mtree pre-su-install \ pre-su-install-script do-install install-desktop-entries \ @@ -3850,7 +3850,7 @@ .ORDER: ${_PATCH_DEP} ${_PATCH_SEQ} .ORDER: ${_CONFIGURE_DEP} ${_CONFIGURE_SEQ} .ORDER: ${_BUILD_DEP} ${_BUILD_SEQ} -.ORDER: ${_INSTALL_DEP} ${_INSTALL_SEQ} +.ORDER: ${_INSTALL_DEP} ${_INSTALL_SEQ} ${_INSTALL_SUSEQ} .ORDER: ${_PACKAGE_DEP} ${_PACKAGE_SEQ} extract-message: @@ -4521,6 +4521,7 @@ fi; \ done .endif +lib-depends2: lib-depends misc-depends: .if defined(DEPENDS) >Release-Note: >Audit-Trail: >Unformatted: