Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 05 Jun 2016 20:53:21 +0000
From:      bugzilla-noreply@freebsd.org
To:        freebsd-ports-bugs@FreeBSD.org
Subject:   [Bug 209354] mail/davmail: Update to 4.7.2
Message-ID:  <bug-209354-13-YMFVsUoCRf@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-209354-13@https.bugs.freebsd.org/bugzilla/>
References:  <bug-209354-13@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D209354

Jason Unovitch <junovitch@freebsd.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|New                         |In Progress
           Assignee|freebsd-ports-bugs@FreeBSD. |junovitch@freebsd.org
                   |org                         |
                 CC|                            |junovitch@freebsd.org

--- Comment #5 from Jason Unovitch <junovitch@freebsd.org> ---
I think the non-root is certainly a good best practice but don't see that as
enough to merge to quarterly without a known issue against it.

I have some issues with the patch.

1. It fails to even start because it doesn't make the users.

# service davmail onestart
install: unknown group davmail

It needs:
USERS=3D  davmail
GROUPS=3D davmail

2. It doesn't make the pidfile directory

# service davmail onestart
install: mkdir : No such file or directory

The davmail.in should probably do something more like:
pidfiledir=3D"/var/run/davmail"
pidfile=3D"${pidfiledir}/davmail.pid"

${pidfiledir} is currently undefined, hense the error.

3. davmail_daemon() also hard codes the username... it should be
${davmail_user}.

Even after all that the service doesn't actually start.  If you can update =
the
patch and verify it runs I'll go ahead and review this for commit.  Thanks.

--=20
You are receiving this mail because:
You are the assignee for the bug.
You are on the CC list for the bug.=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-209354-13-YMFVsUoCRf>