From owner-cvs-src@FreeBSD.ORG Fri Jan 4 18:42:42 2008 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id DED1516A417 for ; Fri, 4 Jan 2008 18:42:42 +0000 (UTC) (envelope-from joerg@britannica.bec.de) Received: from www.pkgsrc-box.org (www.ostsee-abc.de [62.206.222.50]) by mx1.freebsd.org (Postfix) with ESMTP id A103313C44B for ; Fri, 4 Jan 2008 18:42:42 +0000 (UTC) (envelope-from joerg@britannica.bec.de) Received: from britannica.bec.de (www.pkgsrc-box.org [127.0.0.1]) by www.pkgsrc-box.org (Postfix) with ESMTP id B2D51E7BA9E for ; Fri, 4 Jan 2008 18:22:30 +0000 (UTC) Received: by britannica.bec.de (Postfix, from userid 1000) id 9EBBE175CA; Fri, 4 Jan 2008 19:17:28 +0100 (CET) Date: Fri, 4 Jan 2008 19:17:28 +0100 From: Joerg Sonnenberger To: cvs-src@freebsd.org Message-ID: <20080104181728.GM971@britannica.bec.de> References: <200801031830.m03IUb9K049549@repoman.freebsd.org> <477E71F1.4080301@freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <477E71F1.4080301@freebsd.org> User-Agent: Mutt/1.5.16 (2007-06-09) Subject: Re: cvs commit: src/lib/libarchive archive_endian.h archive_read_support_format_zip.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Jan 2008 18:42:43 -0000 On Fri, Jan 04, 2008 at 09:50:41AM -0800, Tim Kientzle wrote: >> +be32dec(const void *pp) >> +{ >> + unsigned char const *p = (unsigned char const *)pp; > > The "const *" is harmless enough, but dropping the > leading "const" doesn't seem right at all: 'pp' > is a pointer to const data, 'p' points to > modifiable data. This is just reordered. unsigned char const * == const unsigned char *. Joerg