From owner-freebsd-arch@freebsd.org  Thu May 19 11:04:30 2016
Return-Path: <owner-freebsd-arch@freebsd.org>
Delivered-To: freebsd-arch@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 373A5B4277F
 for <freebsd-arch@mailman.ysv.freebsd.org>;
 Thu, 19 May 2016 11:04:30 +0000 (UTC)
 (envelope-from phk@phk.freebsd.dk)
Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org
 [IPv6:2001:1900:2254:206a::50:5])
 by mx1.freebsd.org (Postfix) with ESMTP id 27CCE1E34
 for <freebsd-arch@freebsd.org>; Thu, 19 May 2016 11:04:30 +0000 (UTC)
 (envelope-from phk@phk.freebsd.dk)
Received: by mailman.ysv.freebsd.org (Postfix)
 id 23927B4277D; Thu, 19 May 2016 11:04:30 +0000 (UTC)
Delivered-To: arch@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 23034B4277B;
 Thu, 19 May 2016 11:04:30 +0000 (UTC)
 (envelope-from phk@phk.freebsd.dk)
Received: from phk.freebsd.dk (phk.freebsd.dk [130.225.244.222])
 by mx1.freebsd.org (Postfix) with ESMTP id E55901E32;
 Thu, 19 May 2016 11:04:29 +0000 (UTC)
 (envelope-from phk@phk.freebsd.dk)
Received: from critter.freebsd.dk (unknown [192.168.55.3])
 by phk.freebsd.dk (Postfix) with ESMTP id 58CEE4FB1D;
 Thu, 19 May 2016 11:04:22 +0000 (UTC)
Received: from critter.freebsd.dk (localhost [127.0.0.1])
 by critter.freebsd.dk (8.15.2/8.15.2) with ESMTP id u4JB4Lx2085765;
 Thu, 19 May 2016 11:04:21 GMT (envelope-from phk@phk.freebsd.dk)
To: Konstantin Belousov <kostikbel@gmail.com>
cc: geom@freebsd.org, arch@freebsd.org
Subject: Re: Removing Giant asserts from geom
In-reply-to: <20160519105634.GO89104@kib.kiev.ua>
From: "Poul-Henning Kamp" <phk@phk.freebsd.dk>
References: <20160519105634.GO89104@kib.kiev.ua>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <85763.1463655861.1@critter.freebsd.dk>
Date: Thu, 19 May 2016 11:04:21 +0000
Message-ID: <85764.1463655861@critter.freebsd.dk>
X-BeenThere: freebsd-arch@freebsd.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: Discussion related to FreeBSD architecture <freebsd-arch.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-arch>,
 <mailto:freebsd-arch-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-arch/>
List-Post: <mailto:freebsd-arch@freebsd.org>
List-Help: <mailto:freebsd-arch-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-arch>,
 <mailto:freebsd-arch-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 19 May 2016 11:04:30 -0000

--------
In message <20160519105634.GO89104@kib.kiev.ua>, Konstantin Belousov writes:
>I propose to remove asserts
>		mtx_assert(&Giant, MA_NOTOWNED);

By all means.

They were necessary because GEOM happened in the early days of SMP
where things were strange and locks unpredictable.

-- 
Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk@FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe    
Never attribute to malice what can adequately be explained by incompetence.