From owner-svn-ports-all@freebsd.org Sat Oct 19 21:28:44 2019 Return-Path: Delivered-To: svn-ports-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id E320B1571C8; Sat, 19 Oct 2019 21:28:44 +0000 (UTC) (envelope-from egypcio@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46wbcX5ZLWz4fJ2; Sat, 19 Oct 2019 21:28:44 +0000 (UTC) (envelope-from egypcio@freebsd.org) Received: from mail-yw1-f46.google.com (mail-yw1-f46.google.com [209.85.161.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) (Authenticated sender: egypcio) by smtp.freebsd.org (Postfix) with ESMTPSA id 93B67289FC; Sat, 19 Oct 2019 21:28:44 +0000 (UTC) (envelope-from egypcio@freebsd.org) Received: by mail-yw1-f46.google.com with SMTP id s6so3507694ywe.5; Sat, 19 Oct 2019 14:28:44 -0700 (PDT) X-Gm-Message-State: APjAAAWyOSlerJlUfQ9UkRtv+uWoVD9IZexWGcfW4qcViR8meUIZVNhA qpHVxcPA+ai035v4KYa7JoJnNFyhfyqSPxyh1t0= X-Google-Smtp-Source: APXvYqw2nV3FohVqPNQBUzOaL7xUVIKGjddiEU76uDSV1gT9WJ/QWV2vPKj6r9z24b798raPipYbCORGD2CTp8uOHFM= X-Received: by 2002:a81:f101:: with SMTP id h1mr11811014ywm.446.1571520523909; Sat, 19 Oct 2019 14:28:43 -0700 (PDT) MIME-Version: 1.0 References: <201910031250.x93Coclr080961@repo.freebsd.org> In-Reply-To: Reply-To: egypcio@freebsd.org From: =?UTF-8?Q?Vin=C3=ADcius_Zavam?= Date: Sat, 19 Oct 2019 21:28:32 +0000 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r513663 - head/www/py-lektor To: koobs@freebsd.org Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 19 Oct 2019 21:28:45 -0000 adding to my TODO here. thanks! Am Fr., 4. Okt. 2019 um 02:30 Uhr schrieb Kubilay Kocak = : > On 3/10/2019 10:50 pm, Vin=C3=ADcius Zavam wrote: > > Author: egypcio > > Date: Thu Oct 3 12:50:38 2019 > > New Revision: 513663 > > URL: https://svnweb.freebsd.org/changeset/ports/513663 > > > > Log: > > www/py-lektor: add devel/py-pip to RUN_DEPENDS > > > > - Makefile > > based on upstream's setup.py, adding 'pip' to RUN_DEPENDS; > > without 'pip' the lektor application wouldn't work as expected. > > > > https://github.com/lektor/lektor/blob/3.1.3/setup.py > > > > Modified: > > head/www/py-lektor/Makefile > > > > Modified: head/www/py-lektor/Makefile > > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > > --- head/www/py-lektor/Makefile Thu Oct 3 11:18:02 2019 > (r513662) > > +++ head/www/py-lektor/Makefile Thu Oct 3 12:50:38 2019 > (r513663) > > @@ -2,6 +2,7 @@ > > > > PORTNAME=3D Lektor > > PORTVERSION=3D 3.1.3 > > +PORTREVISION=3D 1 > > CATEGORIES=3D www devel python > > MASTER_SITES=3D CHEESESHOP > > PKGNAMEPREFIX=3D ${PYTHON_PKGNAMEPREFIX} > > @@ -20,7 +21,8 @@ RUN_DEPENDS=3D > ${PYTHON_PKGNAMEPREFIX}Jinja2>=3D2.4:devel/ > > ${PYTHON_PKGNAMEPREFIX}Babel>=3D0:devel/py-babel@${PY_FLA= VOR} > \ > > ${PYTHON_PKGNAMEPREFIX}setuptools>=3D0:devel/py-setuptool= s@${PY_FLAVOR} > \ > > ${PYTHON_PKGNAMEPREFIX}requests>=3D0:www/py-requests@${PY= _FLAVOR} > \ > > - ${PYTHON_PKGNAMEPREFIX}inifile>=3D0.4:devel/py-inifile@ > ${PY_FLAVOR} > > + ${PYTHON_PKGNAMEPREFIX}inifile>=3D0.4:devel/py-inifile@${= PY_FLAVOR} > \ > > + ${PYTHON_PKGNAMEPREFIX}pip>=3D0:devel/py-pip@${PY_FLAVOR} > > > > USES=3D python > > USE_PYTHON=3D autoplist distutils > > > > The only place pip is used is in WRKSRC/lektor/packages.py > > def download_and_install_package > def install_local_package > > And pip should not be used to install dependencies > > pip should be removed from (patched out of) from install_requires and > *_requires (extras_require, etc) used instead to describe > additional/extra/non-compulsory dependencies) > > This should be sent/fixed upstream. >