Date: Thu, 27 Mar 1997 17:35:52 -0700 (MST) From: Nate Williams <nate@mt.sri.com> To: Bruce Evans <bde@zeta.org.au> Cc: nate@mt.sri.com, current@freebsd.org, mpp@freefall.freebsd.org Subject: Re: dumpfs patch for review Message-ID: <199703280035.RAA14046@rocky.mt.sri.com> In-Reply-To: <199703280002.LAA10496@godzilla.zeta.org.au> References: <199703280002.LAA10496@godzilla.zeta.org.au>
next in thread | previous in thread | raw e-mail | index | archive | help
> >> It's still ugly. > > > >It's better than nothing... > > It's worse than not printing the new fields. I beg to differ. > >> >+ afs.fs_id[1], ctime((time_t *)&afs.fs_id[0])); > >> ^^^^^^^^^^ > >> > >> Bogus cast. Just as wrong as the one in fsirand.c. > > > >Since fs_id[0] is declared as int_32, I have to cast it to time_t in > >order for it to be 'right' (according to fsirand). > > As I said, fsirand is wrong too. It converts the pointer, not the object. > If time_t is 64 bits then the pointer would probably point to 32 bits of > data and 32 bits of garbage. But it's not. Do you propose changing the definition in /sys/fs/ffs/fs.h? > >> The minfree...maxbpg line shouldn't be changed. > > > >Why not change them? We had to change something? > > Nothing was broken in that line. To make a cake, you gotta break a few eggs. :) Nate
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199703280035.RAA14046>