From owner-freebsd-current Thu Mar 27 16:36:07 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id QAA07381 for current-outgoing; Thu, 27 Mar 1997 16:36:07 -0800 (PST) Received: from rocky.mt.sri.com (rocky.mt.sri.com [206.127.76.100]) by freefall.freebsd.org (8.8.5/8.8.5) with ESMTP id QAA07363 for ; Thu, 27 Mar 1997 16:35:59 -0800 (PST) Received: (from nate@localhost) by rocky.mt.sri.com (8.7.5/8.7.3) id RAA14046; Thu, 27 Mar 1997 17:35:52 -0700 (MST) Date: Thu, 27 Mar 1997 17:35:52 -0700 (MST) Message-Id: <199703280035.RAA14046@rocky.mt.sri.com> From: Nate Williams MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit To: Bruce Evans Cc: nate@mt.sri.com, current@freebsd.org, mpp@freefall.freebsd.org Subject: Re: dumpfs patch for review In-Reply-To: <199703280002.LAA10496@godzilla.zeta.org.au> References: <199703280002.LAA10496@godzilla.zeta.org.au> X-Mailer: VM 6.22 under 19.14 XEmacs Lucid Sender: owner-current@freebsd.org X-Loop: FreeBSD.org Precedence: bulk > >> It's still ugly. > > > >It's better than nothing... > > It's worse than not printing the new fields. I beg to differ. > >> >+ afs.fs_id[1], ctime((time_t *)&afs.fs_id[0])); > >> ^^^^^^^^^^ > >> > >> Bogus cast. Just as wrong as the one in fsirand.c. > > > >Since fs_id[0] is declared as int_32, I have to cast it to time_t in > >order for it to be 'right' (according to fsirand). > > As I said, fsirand is wrong too. It converts the pointer, not the object. > If time_t is 64 bits then the pointer would probably point to 32 bits of > data and 32 bits of garbage. But it's not. Do you propose changing the definition in /sys/fs/ffs/fs.h? > >> The minfree...maxbpg line shouldn't be changed. > > > >Why not change them? We had to change something? > > Nothing was broken in that line. To make a cake, you gotta break a few eggs. :) Nate