From owner-svn-ports-all@freebsd.org Fri Jul 17 05:14:46 2015 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id C7E049A4112; Fri, 17 Jul 2015 05:14:46 +0000 (UTC) (envelope-from adamw@adamw.org) Received: from apnoea.adamw.org (apnoea.adamw.org [204.109.59.150]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "abg.ninja", Issuer "Gandi Standard SSL CA 2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id E96B11CB5; Fri, 17 Jul 2015 05:14:43 +0000 (UTC) (envelope-from adamw@adamw.org) Received: by apnoea.adamw.org (OpenSMTPD) with ESMTPSA id 1bbbd7d8 TLS version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-SHA bits=256 verify=NO; Thu, 16 Jul 2015 23:14:33 -0600 (MDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2102\)) Subject: Re: svn commit: r392209 - in head/devel: . p5-Minilla From: Adam Weinberger In-Reply-To: <20150716153045.GB21677@FreeBSD.org> Date: Thu, 16 Jul 2015 22:14:31 -0700 Cc: Baptiste Daroussin , Mathieu Arnold , Dmitry Marakasov , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: <02A72E36-1D93-42EF-85FA-D3AA8B0D667E@adamw.org> References: <201507152017.t6FKHElA056017@svnmir.geo.freebsd.org> <20150716014306.GA68880@FreeBSD.org> <20150716091021.GW37597@ivaldir.etoilebsd.net> <20150716092053.GX37597@ivaldir.etoilebsd.net> <20150716145201.GA13745@FreeBSD.org> <20150716145920.GY37597@ivaldir.etoilebsd.net> <20150716151730.GA21677@FreeBSD.org> <20150716152043.GZ37597@ivaldir.etoilebsd.net> <20150716153045.GB21677@FreeBSD.org> To: Alexey Dokuchaev X-Mailer: Apple Mail (2.2102) X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Jul 2015 05:14:46 -0000 > On 16 Jul, 2015, at 8:30, Alexey Dokuchaev wrote: >=20 > On Thu, Jul 16, 2015 at 05:20:44PM +0200, Baptiste Daroussin wrote: >> On Thu, Jul 16, 2015 at 03:17:30PM +0000, Alexey Dokuchaev wrote: >>> Fair enough; [...] lets make it easier for new folks to get a hold = of >>> things, no problem. >>>=20 >>> But forbidding a 100% perfectly valid, supported, and documented = syntax >>> used in good will and intention by an experienced developer is IMO = wrong. >>=20 >> Given the number of times I had fixed side effect of this I bet I'm = would >> like to know how many people really knows how make(1) works :) in = particular >> in that area. >=20 > When sat@ was actively doing his peer reviews, he would've always = point it > out to folks that misused lazy vs. immediate expansion. Too bad he's = no > longer active; I think that rather than trying to avoid sharp corners = of our > make(1), or any tool FWIW, we should be doing continuous education = work akin > to what he did... >=20 >> With the new way of validating dependencies (where the pattern is now = also >> checked after the dependency is installed, people would now quickly = noticed >> but before this recent change it was most of the time silent. = poudriere was >> the only tool able to notice that). >=20 > This actually brings us to another rule which makes more sense to = become a > "hard" one: DO NOT commit ports work without poudriere/tinderbox test = run. I=E2=80=99d just like to mention PR 191273, which suggesting adding a = new depends macro that registers a BUILD_ and RUN_DEPENDS. BUILDANDRUN_DEPENDS=3D foo:... (Or something. I=E2=80=99m terrible at naming things, but the = concept/patch is there.) By way of examples, a huge percentage of Perl modules rely on :=3D, and = many of them perform impressive manoeuvres to assign RUN_DEPENDS:=3D ${BUILD_DEPENDS} BUILD_DEPENDS+=3D =E2=80=A6 or my favorite BUILD_DEPENDS=3D foo:... RUN_DEPENDS:=3D ${BUILD_DEPENDS:Nfoo*} The fact that not even the PHB was clear on whether :=3D was correct = suggests that there is a problem that can use a solution. # Adam =E2=80=94 Adam Weinberger adamw@adamw.org http://www.adamw.org