From owner-cvs-all  Mon Dec  9 11:58:14 2002
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id C73C637B401
	for <cvs-all@freebsd.org>; Mon,  9 Dec 2002 11:58:13 -0800 (PST)
Received: from rootlabs.com (root.org [67.118.192.226])
	by mx1.FreeBSD.org (Postfix) with SMTP id D7AE643ED4
	for <cvs-all@freebsd.org>; Mon,  9 Dec 2002 11:58:08 -0800 (PST)
	(envelope-from nate@rootlabs.com)
Received: (qmail 25290 invoked by uid 1000); 9 Dec 2002 19:58:09 -0000
Date: Mon, 9 Dec 2002 11:58:09 -0800 (PST)
From: Nate Lawson <nate@root.org>
To: Josef Karthauser <joe@FreeBSD.org>
Cc: cvs-all@freebsd.org, cvs-committers@freebsd.org
Subject: Re: cvs commit: src/sys/dev/usb ohci.c
In-Reply-To: <20021209014609.9F72F37B50C@hub.freebsd.org>
Message-ID: <Pine.BSF.4.21.0212091149270.25027-100000@root.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG

On Sun, 8 Dec 2002, Josef Karthauser wrote:
> joe         2002/12/08 17:41:24 PST
> 
>   Modified files:
>     sys/dev/usb          ohci.c 
>   Log:
>   MFNetBSD: (partial 1.133)
>   - In ohci_close_pipe, wait 1ms after removing an ED to avoid possible race
>     condition.
>   
>   Approved by:    re (rwatson)

Wouldn't it be better to use a mtx or tsleep/wakeup?  A delay leaves the
race, only making it non-deterministic.

-Nate


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message