Date: Sun, 13 Sep 2015 00:00:48 +0900 From: Hajimu UMEMOTO <ume@FreeBSD.org> To: marino@freebsd.org Cc: Mathieu Arnold <mat@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r396689 - in head/mail: cyrus-imapd23 cyrus-imapd24 cyrus-imapd25 Message-ID: <ygewpvvvg0v.wl-ume@FreeBSD.org> In-Reply-To: <55F43C0A.7050307@marino.st> References: <201509111758.t8BHwjA5064734@repo.freebsd.org> <ygezj0suf7x.wl-ume@FreeBSD.org> <D8CB01F5D2938F2E37E9593F@atuin.in.mat.cc> <ygey4gbvgp6.wl-ume@FreeBSD.org> <55F43C0A.7050307@marino.st>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi, >>>>> On Sat, 12 Sep 2015 16:51:54 +0200 >>>>> John Marino <freebsd.contact@marino.st> said: > mat> | It seems your changes have many reasons. It is hard to inspect > mat> | whether it becomes equivalent to the one I intended. Could you back > mat> | all of your changes out, then separate every change reason and send > mat> | your proposed diffs to me. > > mat> With respect, no. The thing that you wanted, that is, the man pages > mat> definitions in the Makefie are back where they were. All the other changes > mat> are things the framework was already doing and that you were duplicating. > > Then, I'll back them out by myself, sigh. It is hard to inspect > whether it becomes equivalent to the one I intended. You could make > me be disappointed at your effort. freebsd.contact> I think this would be an example of bad citizenship. You have no reason freebsd.contact> to think Matt's commits are wrong. Unless you have some evidence they freebsd.contact> are, you should assume they are correct. That also gives you lots and freebsd.contact> lots of time to go through the changes at your pace. freebsd.contact> I really don't want to see good changes backed out for bad code, which freebsd.contact> is what it is being described as. Does poudriere pass QA checks or not? freebsd.contact> If it does, then the port is working as intended, right? Again, it is hard to inspect whether it becomes equivalent to the one I intended. The commit was done, violently. Isn't it enough reason for you? At least, it seems different from something I intend in DOCS. Sincerely, -- Hajimu UMEMOTO ume@mahoroba.org ume@FreeBSD.org http://www.mahoroba.org/~ume/
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?ygewpvvvg0v.wl-ume>