From owner-svn-src-stable@freebsd.org Wed Apr 25 02:42:30 2018 Return-Path: Delivered-To: svn-src-stable@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 3FCF0FBB284 for ; Wed, 25 Apr 2018 02:42:30 +0000 (UTC) (envelope-from pfg@FreeBSD.org) Received: from sonic303-35.consmr.mail.gq1.yahoo.com (sonic303-35.consmr.mail.gq1.yahoo.com [98.137.64.216]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 1158D85BB2 for ; Wed, 25 Apr 2018 02:42:28 +0000 (UTC) (envelope-from pfg@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1524624147; bh=CdqphuehXMbNsPN9zULhocC5NCViPvyvvNoby0wNSgw=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From:Subject; b=cTdiZLp/rqgxX4yylBUOm7dGhoZ3886r53P+q4JlC3hMJpVCWgEuGU3j5RRoykYRcXOZ7VDBt22lKAe6iVO4C8GBr0DbePFuyBuCnZbfNDOMmjB/hNYVhw7eyS5opnpRlj0aP8+9OW9K1fV0JVtRP9kMXiHLjO5ks2g+xAM3sLEORXXLOpaejUIgjX5VbPZaZe6IMk/HfOcqQOkYXoVy77mr3CadAe49KgKqF3o2iEKtgYGyqoT17PsJHo7mm1V9MFCZo9caQ2kh48JWt228EJ3aYvrxNk5KY3z5y/w4G7N88YO2xJ2XNLTEwsE/3Sp+CwKTKPLz9K0NXrhxeVqWFQ== X-YMail-OSG: HXeLUlMVM1nhj.cTiU2NSQZNKtUKlrkwzKJOj3QX65UFJF9UQxI8IMLpbcX6CN. e__PXFTgdH7a6KbfpMXealUMMwZa6_78odDNRraIPOoOrH6AMF26_Hv8fPAcTR6h_HJVMcGBdLCx WruUUHIO5Lw1VJRvy18J7o1WDi26tM1UfS3ZWHT.q57ksNoLLVuo6KqoEQgQPEI_g4RrlH8YQIsn EGi6fW1ZEJCLg00YWLXlEsmPk_5qVJuuSdxiHDLoe6bz9aiuHnbePnplxba0zH7Ws9EeU16pBtMd TSFJGotr2SM_AkAO5c7jXLQz3JHRbGMVOnr9eG1npS.Vr_wNQleJMLKeyBD0rftrwhVFRBOa.R_O RYyOpQvJm2rJBseHxBJjEXZl95kMiUVRzqvIDr6WzKdg5Gp40WbUehSn.V0hnUBs7lGH3u3xynLX MQGZAIS0U4lpN1hDQn.8wtJmdTyQ9xphVHjfvFihdBph_iCN4xEPRGhJ9PgPFqz0PlQsr0BRl65h IBlpO6GzgBfbVNYAluUNBfPSXvAkdoCpRwzgl8uQs7_JzUlyTOogOliOSJ6RlJGparPP01dv7xWI u1nESYTO41yW_rym4p89Rg50B8rwcvskM1nku Received: from sonic.gate.mail.ne1.yahoo.com by sonic303.consmr.mail.gq1.yahoo.com with HTTP; Wed, 25 Apr 2018 02:42:27 +0000 Received: from 181.52.72.201 (EHLO [192.168.0.6]) ([181.52.72.201]) by smtp403.mail.gq1.yahoo.com (Oath Hermes SMTP Server) with ESMTPA ID b4b12013f2c7d866bef0253f43d72af1; Wed, 25 Apr 2018 02:42:23 +0000 (UTC) Subject: Re: svn commit: r332980 - in stable/11/usr.sbin/makefs: . cd9660 ffs To: Benno Rice Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-11@freebsd.org References: <201804250135.w3P1Z6Xt084500@repo.freebsd.org> <4E691A4E-6391-4A7D-BD8E-C2773C564AC2@FreeBSD.org> From: Pedro Giffuni Message-ID: Date: Tue, 24 Apr 2018 21:42:21 -0500 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <4E691A4E-6391-4A7D-BD8E-C2773C564AC2@FreeBSD.org> Content-Language: en-US Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-Content-Filtered-By: Mailman/MimeDel 2.1.25 X-BeenThere: svn-src-stable@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for all the -stable branches of the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Apr 2018 02:42:30 -0000 On 04/24/18 21:15, Benno Rice wrote: > > >> On Apr 24, 2018, at 9:50 PM, Pedro Giffuni > > wrote: >> >> >> >> On 24/04/2018 20:35, Benno Rice wrote: >>> Author: benno >>> Date: Wed Apr 25 01:35:06 2018 >>> New Revision: 332980 >>> URL: https://svnweb.freebsd.org/changeset/base/332980 >>> >>> Log: >>>   MFC r307927 >>>       Be more precise when including headers so that we're less >>> likely to >>>    depend on namespace pollution and as such become more portable. This >>>    means including headers like or , but also >>>    making sure we include system/host headers before local headers. >>>       While here: define ENOATTR as ENOMSG in mtree.c. There is no >>> ENOATTR >>>    on Linux. >>> >> Nope. >> ... >> >>> Modified: stable/11/usr.sbin/makefs/mtree.c >>> ============================================================================== >>> --- stable/11/usr.sbin/makefs/mtree.cWed Apr 25 01:30:29 2018(r332979) >>> +++ stable/11/usr.sbin/makefs/mtree.cWed Apr 25 01:35:06 2018(r332980) >>> @@ -46,10 +46,15 @@ __FBSDID("$FreeBSD$"); >>>  #include >>>  #include >>>  #include >>> +#include >>>  #include >>>  #include >>>    #include "makefs.h" >>> + >>> +#ifndef ENOATTR >>> +#defineENOATTRENOMSG >>> +#endif >>>    #defineIS_DOT(nm)((nm)[0] == '.' && (nm)[1] == '\0') >>>  #defineIS_DOTDOT(nm)((nm)[0] == '.' && (nm)[1] == '.' && (nm)[2] == >>> '\0') >> >> This should be ENODATA, see r326282 for reference. > > This is an old change I MFC’ed but did not originally author. Merging > it reduced conflicts with other changes I needed to merge in order to > merge the EFI changes for El Torito. I’m more than happy if someone > wants to fix this up in head. > I see, good find then ;). Thanks, Pedro.