From owner-freebsd-eclipse@FreeBSD.ORG Mon Sep 10 07:37:31 2007 Return-Path: Delivered-To: freebsd-eclipse@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0EBB216A417 for ; Mon, 10 Sep 2007 07:37:31 +0000 (UTC) (envelope-from dan@rucci.org) Received: from mta2.srv.hcvlny.cv.net (mta2.srv.hcvlny.cv.net [167.206.4.197]) by mx1.freebsd.org (Postfix) with ESMTP id C2D7413C458 for ; Mon, 10 Sep 2007 07:37:30 +0000 (UTC) (envelope-from dan@rucci.org) Received: from izer.warganizer.com (ool-182eb907.dyn.optonline.net [24.46.185.7]) by mta2.srv.hcvlny.cv.net (Sun Java System Messaging Server 6.2-8.04 (built Feb 28 2007)) with ESMTP id <0JO500KK86IFFF90@mta2.srv.hcvlny.cv.net> for freebsd-eclipse@freebsd.org; Mon, 10 Sep 2007 03:37:28 -0400 (EDT) Date: Mon, 10 Sep 2007 03:38:54 -0400 From: Daniel Rucci In-reply-to: <20070909191227.GA12241@misty.eyesbeyond.com> To: Greg Lewis Message-id: <46E4F48E.2090904@rucci.org> MIME-version: 1.0 Content-type: text/plain; charset=ISO-8859-1 Content-transfer-encoding: 7BIT X-Enigmail-Version: 0.95.0 References: <46E308C1.8040501@buzmo.com> <20070909.114656.104027741.ken@tydfam.jp> <46E38E90.5090606@buzmo.com> <20070909.183337.115905635.ken@tydfam.jp> <46E413CE.5050209@buzmo.com> <20070909191227.GA12241@misty.eyesbeyond.com> User-Agent: Thunderbird 2.0.0.6 (X11/20070806) Cc: freebsd-eclipse@freebsd.org Subject: Re: eclipse 3.3.0 X-BeenThere: freebsd-eclipse@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "FreeBSD users of eclipse EDI, tools, rich client apps & ports." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 10 Sep 2007 07:37:31 -0000 Greg Lewis wrote: > On Sun, Sep 09, 2007 at 08:39:58AM -0700, Mike Bowie wrote: >> Ken Yamada wrote: >>> Opps! >>> >>> You missed ${WRKSRC} in ${CP}. >>> It needs to be ; >>> >>> do-build: >>> @(cd ${WRKSRC}; ${SETENV} ${MAKE_ENV} \ >>> ./build -os ${ECLIPSE_OS} -ws ${ECLIPSE_WS} -arch ${ECLIPSE_ARCH} >>> -comp >>> ilelibs) >>> @${CP} >>> ${WRKSRC}/launchertmp/library/${ECLIPSE_WS}/eclipse_1017a.so \ >>> ${WRKSRC}/eclipse/plugins/org.eclipse.equinox.launcher.${ECLIPSE_WS}.${ECLIPSE_OS}.${ECLIPSE_ARCH}_1.0.0.v20070606 >>> >>> Yes, it works - better than I thought..., but, we may better tailor >>> build.xml further before committing as a port so that we can port next >>> version easier... >> Ah yes! That's what I get for rushing through! >> >> http://www.buzmo.com/projects/eclipse-europa-port/Makefile-090907.diff >> has said fix included. (Ironically enough, made manually to the diff >> and untested... will I never learn?!?) >> >> And you're right on your second point too, it does work very well. > > Sounds like its good enough to at least commit to eclipse-devel? > http://rucci.org/ports/java/eclipse-europa/ contains a 'cleaned up' version of the port: * Included Mikes Makefile diff * Removed unused files (or at least most of them?) * ran portlint -A as per the porters-handbook and made some changes to the Makefile to get rid of the errors, now it just gives the following warnings: WARN: Makefile: possible use of absolute pathname "/dev/null". WARN: Makefile: "LIB_DEPENDS" has to appear earlier. portlint also suggests that programs such as eclipse should not list java as its main category, I am not sure if we should follow its recommendation or stick with the rest of the eclipse related ports. (or maybe ports/eclipse/* ). Dan