Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 6 Nov 2013 08:56:27 +0000
From:      Alexey Dokuchaev <danfe@FreeBSD.org>
To:        Ganael LAPLANCHE <martymac@FreeBSD.org>
Cc:        svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org
Subject:   Re: svn commit: r332954 - head/sysutils/fpart
Message-ID:  <20131106085627.GC90001@FreeBSD.org>
In-Reply-To: <201311060814.rA68Ebi8077759@svn.freebsd.org>
References:  <201311060814.rA68Ebi8077759@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Nov 06, 2013 at 08:14:37AM +0000, Ganael LAPLANCHE wrote:
> New Revision: 332954
> URL: http://svnweb.freebsd.org/changeset/ports/332954
> 
>  post-install:
>  .if ${PORT_OPTIONS:MDOCS}
> -	${MKDIR} ${DOCSDIR}
> +	${MKDIR} ${STAGEDIR}${DOCSDIR}
>  .for doc in ${PORTDOCS}
> -	${INSTALL_DATA} ${WRKSRC}/${doc} ${DOCSDIR}
> +	${INSTALL_DATA} ${WRKSRC}/${doc} ${STAGEDIR}${DOCSDIR}

In staging mode, it is no longer required to check for PORT_OPTIONS:MDOCS
(unless docs are actually being built via external dependency like Doxygen
or simply take way too much disk space).  Dropping the check would also
allow you to not include anything other than b.p.m.

You could have also got rid of ".for doc in ${PORTDOCS}" loop by using this
nice little trick:

    ${INSTALL_DATA} ${PORTDOCS:S|^|${WRKSRC}/|} ${STAGEDIR}${DOCSDIR}

./danfe



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20131106085627.GC90001>