From owner-svn-ports-head@FreeBSD.ORG Thu Sep 25 13:42:35 2014 Return-Path: Delivered-To: svn-ports-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 1D4217D0; Thu, 25 Sep 2014 13:42:35 +0000 (UTC) Received: from mailrelay005.isp.belgacom.be (mailrelay005.isp.belgacom.be [195.238.6.171]) by mx1.freebsd.org (Postfix) with ESMTP id 1657DEE6; Thu, 25 Sep 2014 13:42:33 +0000 (UTC) X-Belgacom-Dynamic: yes X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ApgGANMZJFRbsISZ/2dsb2JhbABggw5TTQrKaodOAoEBFwF7hAMBAQEDATocIxALDgYECSUPKh4GE4g2DAEIwisBF49rMweESwEElhqHCIFjk3SDZTsvgkoBAQE Received: from 153.132-176-91.adsl-dyn.isp.belgacom.be (HELO kalimero.tijl.coosemans.org) ([91.176.132.153]) by relay.skynet.be with ESMTP; 25 Sep 2014 15:42:26 +0200 Received: from kalimero.tijl.coosemans.org (kalimero.tijl.coosemans.org [127.0.0.1]) by kalimero.tijl.coosemans.org (8.14.9/8.14.9) with ESMTP id s8PDgOSi006854; Thu, 25 Sep 2014 15:42:24 +0200 (CEST) (envelope-from tijl@FreeBSD.org) Date: Thu, 25 Sep 2014 15:42:24 +0200 From: Tijl Coosemans To: Pietro Cerutti Subject: Re: svn commit: r369243 - head/net/trickle Message-ID: <20140925154224.5a539872@kalimero.tijl.coosemans.org> In-Reply-To: <20140925130610.GI64676@ptrcrt.ch> References: <201409251159.s8PBxlVV030182@svn.freebsd.org> <20140925145326.4b190667@kalimero.tijl.coosemans.org> <20140925130610.GI64676@ptrcrt.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, bdrewery@FreeBSD.org, ports-committers@freebsd.org X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 25 Sep 2014 13:42:35 -0000 On Thu, 25 Sep 2014 15:06:10 +0200 Pietro Cerutti wrote: > On 2014-Sep-25, 14:53, Tijl Coosemans wrote: >> On Thu, 25 Sep 2014 11:59:47 +0000 (UTC) Pietro Cerutti wrote: >>> Author: gahr >>> Date: Thu Sep 25 11:59:46 2014 >>> New Revision: 369243 >>> URL: http://svnweb.freebsd.org/changeset/ports/369243 >>> QAT: https://qat.redports.org/buildarchive/r369243/ >>> >>> Log: >>> - Generate position independent code >>> - Perhaps this fixes the build on head-amd64-default-ssp >>> >>> Modified: >>> head/net/trickle/Makefile >>> >>> Modified: head/net/trickle/Makefile >>> ============================================================================== >>> --- head/net/trickle/Makefile Thu Sep 25 11:35:43 2014 (r369242) >>> +++ head/net/trickle/Makefile Thu Sep 25 11:59:46 2014 (r369243) >>> @@ -22,7 +22,7 @@ MAKE_JOBS_UNSAFE= yes >>> >>> CONFIGURE_ARGS+=--with-libevent=${LOCALBASE} \ >>> --sysconfdir=${PREFIX}/etc >>> -CPPFLAGS+= -I${LOCALBASE}/include >>> +CPPFLAGS+= -I${LOCALBASE}/include -fPIC >> >> The problem with adding -fPIC like that is that it causes everything >> to be compiled with it, including executables and static libraries >> while normally only shared libraries need it. > > Is this a problem? Depends on what you call problem. It's a performance issue. PIC is slower than non-PIC. For executables there's -fPIE which is a bit less slow. >> In the configure output for the SSP build it says: >> >> checking if cc PIC flag -fPIC works... no >> >> >> Can you check config.log to see why this test fails? > > No, I don't have the working directory myself. Anyway, it looks like > it fails to link because -fPIC wasn't specified, not that it fails to > compile because of the -fPIC flag. Or am I missing something? The first yes, but the reason it isn't specified is because the configure check fails. The reason the configure check fails seems to be because the SSP package builder uses ccache. It doesn't support clang properly. I think you can just revert the commit. It is not needed at all. You can test it with "make -DWITH_SSP_PORTS".