Date: Fri, 15 Mar 2013 16:20:24 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: Beech Rintoul <beech@FreeBSD.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r314244 - head/graphics/synaesthesia Message-ID: <20130315162023.GA44448@FreeBSD.org> In-Reply-To: <20130315035354.GA75883@FreeBSD.org> References: <201303150248.r2F2mtfk027871@svn.freebsd.org> <20130315035354.GA75883@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Mar 15, 2013 at 03:53:54AM +0000, Alexey Dokuchaev wrote: > On Fri, Mar 15, 2013 at 02:48:55AM +0000, Beech Rintoul wrote: > > New Revision: 314244 > > URL: http://svnweb.freebsd.org/changeset/ports/314244 > > > > +.if ${PORT_OPTIONS:MDOCS} > > + @${MKDIR} ${DOCSDIR} > > + ${INSTALL_DATA} ${PORTDOCS:S|^|${WRKSRC}/|} ${DOCSDIR} > > +PLIST_FILES+= %%DOCSDIR%%/README > > +PLIST_DIRS+= %%DOCSDIR%% > > Why not move out these two lines out of .if (it looks very ugly and it's > generally bad idea to mix code with declarations) and turn them into > PORTDOCS (can be set unconditionally)? Fixed that for you in r314313, along with other minor changes. ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130315162023.GA44448>