Date: Wed, 29 Jan 2020 20:56:32 +0000 (UTC) From: Dimitry Andric <dim@FreeBSD.org> To: src-committers@freebsd.org, svn-src-projects@freebsd.org Subject: svn commit: r357267 - projects/clang1000-import/usr.bin/tip/tip Message-ID: <202001292056.00TKuW3t078198@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: dim Date: Wed Jan 29 20:56:31 2020 New Revision: 357267 URL: https://svnweb.freebsd.org/changeset/base/357267 Log: Fix the following -Werror warning from clang 10.0.0 in tip: usr.bin/tip/tip/tip.c:428:4: error: misleading indentation; statement is not part of the previous 'if' [-Werror,-Wmisleading-indentation] if (gch == EOF) ^ usr.bin/tip/tip/tip.c:426:5: note: previous statement is here } else if (!cumode && gch == character(value(FORCE))) ^ The intent was to have the EOF check grouped with the getchar() call just above it. This was accidentally introduced in r354624. MFC after: 3 days Modified: projects/clang1000-import/usr.bin/tip/tip/tip.c Modified: projects/clang1000-import/usr.bin/tip/tip/tip.c ============================================================================== --- projects/clang1000-import/usr.bin/tip/tip/tip.c Wed Jan 29 18:54:21 2020 (r357266) +++ projects/clang1000-import/usr.bin/tip/tip/tip.c Wed Jan 29 20:56:31 2020 (r357267) @@ -423,11 +423,12 @@ tipin(void) if (boolean(value(HALFDUPLEX))) printf("\r\n"); continue; - } else if (!cumode && gch == character(value(FORCE))) + } else if (!cumode && gch == character(value(FORCE))) { gch = getchar(); if (gch == EOF) return; gch = gch & STRIP_PAR; + } bol = any(gch, value(EOL)); if (boolean(value(RAISE)) && islower(gch)) gch = toupper(gch);
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202001292056.00TKuW3t078198>