From owner-cvs-src@FreeBSD.ORG Tue Oct 5 18:08:46 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8019216A4D1 for ; Tue, 5 Oct 2004 18:08:46 +0000 (GMT) Received: from mail3.speakeasy.net (mail3.speakeasy.net [216.254.0.203]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1AEA943D45 for ; Tue, 5 Oct 2004 18:08:46 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: (qmail 20927 invoked from network); 5 Oct 2004 18:08:45 -0000 Received: from dsl027-160-063.atl1.dsl.speakeasy.net (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender ) encrypted SMTP for ; 5 Oct 2004 18:08:45 -0000 Received: from [10.50.40.210] (gw1.twc.weather.com [216.133.140.1]) (authenticated bits=0) by server.baldwin.cx (8.12.11/8.12.11) with ESMTP id i95I8dCh065991; Tue, 5 Oct 2004 14:08:40 -0400 (EDT) (envelope-from jhb@FreeBSD.org) From: John Baldwin To: Nate Lawson Date: Tue, 5 Oct 2004 14:09:30 -0400 User-Agent: KMail/1.6.2 References: <200410050237.LAA20152@axe-inc.co.jp> <4162DEF0.1020809@root.org> In-Reply-To: <4162DEF0.1020809@root.org> MIME-Version: 1.0 Content-Disposition: inline Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <200410051409.30619.jhb@FreeBSD.org> X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on server.baldwin.cx cc: Takanori Watanabe cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org cc: cvs-src@FreeBSD.org Subject: Re: cvs commit: src/usr.sbin/acpi/acpidump acpi.c acpidump.c acpidump.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Oct 2004 18:08:46 -0000 On Tuesday 05 October 2004 01:50 pm, Nate Lawson wrote: > Takanori Watanabe wrote: > > In message <200410050218.i952IrBK008982@repoman.freebsd.org>, Nate Lawson > > wrote > > > >>njl 2004-10-05 02:18:53 UTC > >> > >> FreeBSD src repository > >> > >> Modified files: > >> usr.sbin/acpi/acpidump acpi.c acpidump.c acpidump.h > >> Log: > >> Add the -s flag to make dumping SSDTs optional (disabled by default). > >> Since we can only override the DSDT, a custom ASL dumped previously that > >> contained SSDTs would result in lots of multiple definition errors. > >> > >> A longer-term fix involves adding the ability to override SSDTs to > >> ACPI-CA. > > > > iasl(8) may have to be able to compile multiple AML codes from single > > ASL data, instead of merging SSDT into DSDT in acpidump(8). > > I think the most straightforward fix is for ACPI-CA to not load SSDT > tables when the user is overriding the DSDT. If you treat overridden > SSDTs separately, you go down the path of having to specify _which_ > table you want to override, which implies you need strict ordering of > tables in both ASL and AML and it just gets too complicated. Some HP > Itanium machines have 8 to 10 SSDTs. I agree. It makes the user's lives a lot easier if they procedure remains: - acpidump > foo.asl - hack on foo.asl to fix it - compile foo.asl to foo.dsdt - load foo.dsdt in the loader and have it all just work. Actually, you know, we could make this work on our own without requiring ACPI-CA to change. You just need to hack AcpiOsTableOverride() in OsdTable.c to return a pointer to an empty table for "SSDT" tables when the DSDT is overridden. In fact, I think that is probably where this behavior decision really belongs. -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve" = http://www.FreeBSD.org