From owner-svn-ports-all@FreeBSD.ORG  Fri Aug 22 12:00:33 2014
Return-Path: <owner-svn-ports-all@FreeBSD.ORG>
Delivered-To: svn-ports-all@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 1033)
 id 37E5662E; Fri, 22 Aug 2014 12:00:33 +0000 (UTC)
Date: Fri, 22 Aug 2014 12:00:33 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: Bryan Drewery <bdrewery@FreeBSD.org>
Subject: Re: svn commit: r365590 - in head/cad/spice: . files
Message-ID: <20140822120033.GC2378@FreeBSD.org>
References: <201408211941.s7LJf6de048334@svn.freebsd.org>
 <53F663B2.3000800@marino.st>
 <20140822.070939.1253386656808735449.hrs@allbsd.org>
 <53F66EE5.7080500@FreeBSD.org> <53F6724A.6000602@marino.st>
 <53F69CA6.1060909@FreeBSD.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <53F69CA6.1060909@FreeBSD.org>
User-Agent: Mutt/1.5.23 (2014-03-12)
Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, marino@freebsd.org,
 Hiroki Sato <hrs@FreeBSD.org>, ports-committers@freebsd.org
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 22 Aug 2014 12:00:33 -0000

On Thu, Aug 21, 2014 at 08:28:06PM -0500, Bryan Drewery wrote:
> Regarding this individual change, you have provided no evidence it
> breaks anywhere. And as I've pointed out there are plenty of other ports
> using bsd.prog.mk. 127 files reference it. It is perfectly reasonable
> for someone to use bsd.prog.mk in ports.

The fact that 127 out of ~25K ports are using it is more like indication it
is an exception than "perfectly reasonable" thing.  This is a bug.  This is
needless dependency on src.  Every time I see a port that relies on some
macro from it, it is usually only because people are lazy to write six-line
makefile.  It most likely won't work with staging and/or regular user build
(because of preference to ${INSTALL} ... -o foo -g bar), etc.  Last but not
least, it breaks DragonFly (or BryanBSD, or whatever).

I don't care for DF much, but calling an obvious bug a perfectly reasonable
feature is wrong.

./danfe