From owner-cvs-all Mon Oct 19 17:08:25 1998 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id RAA07717 for cvs-all-outgoing; Mon, 19 Oct 1998 17:08:25 -0700 (PDT) (envelope-from owner-cvs-all@FreeBSD.ORG) Received: from jamesn.locker13.com (nix.what.net [207.136.36.36]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id RAA07566; Mon, 19 Oct 1998 17:07:47 -0700 (PDT) (envelope-from nix!FreeBSD.ORG!majordom@nix.what.net) Received: from localhost (3019 bytes) by jamesn.locker13.com via sendmail with P:stdio/R:bind_hosts/T:inet_zone_bind_smtp (sender: ) (ident using unix) id for ; Mon, 19 Oct 1998 19:04:33 -0500 (CDT) (Smail-3.2.0.101 1997-Dec-17 #2 built 1998-May-10) Received: from nix.UUCP (uucp@localhost) by here.what.net (8.9.1/8.9.1) with UUCP id GAA25430 for jamesn; Sat, 17 Oct 1998 06:19:43 -0500 (CDT) (envelope-from nix!FreeBSD.ORG!majordom) Received: from localhost (2549 bytes) by jamesn.locker13.com via sendmail with P:stdio/R:paths/T:uux (sender: ) (ident using unix) id for ; Sat, 17 Oct 1998 06:17:23 -0500 (CDT) (Smail-3.2.0.101 1997-Dec-17 #2 built 1998-May-10) Received: from hub.freebsd.org(src addr [204.216.27.18]) (2213 bytes) by jamesn.locker13.com via sendmail with P\:esmtp/D:aliases/T:pipe (sender: ) id for ; Sat, 17 Oct 1998 06:17:22 -0500 (CDT) (Smail-3.2.0.101 1997-Dec-17 #2 built 1998-May-10) Delivered-To: vmailer-cvs-all@freebsd.org Received: by hub.freebsd.org (VMailer, from userid 1) id 49E1C9C4B; Sat, 17 Oct 1998 04:17:28 -0700 (PDT) Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id EAA02500 for cvs-all-outgoing; Sat, 17 Oct 1998 04:17:26 -0700 (PDT) (envelope-from owner-cvs-all@FreeBSD.ORG) Received: from time.cdrom.com (time.cdrom.com [204.216.27.226]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id EAA02493; Sat, 17 Oct 1998 04:17:23 -0700 (PDT) (envelope-from jkh@time.cdrom.com) Received: from time.cdrom.com (jkh@localhost.cdrom.com [127.0.0.1]) by time.cdrom.com (8.8.8/8.8.8) with ESMTP id EAA22325; Sat, 17 Oct 1998 04:17:26 -0700 (PDT) (envelope-from jkh@time.cdrom.com) To: Bruce Evans Cc: cvs-all@FreeBSD.ORG, cvs-committers@FreeBSD.ORG, jkh@FreeBSD.ORG Subject: Re: cvs commit: src/sbin/newfs newfs.c In-reply-to: Your message of "Sat, 17 Oct 1998 15:39:17 +1000." <199810170539.PAA02786@godzilla.zeta.org.au> Date: Sat, 17 Oct 1998 04:17:26 -0700 Message-ID: <22321.908623046@time.cdrom.com> From: "Jordan K. Hubbard" Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk > Wrong. The type field isn't already set correctly (any previous setting > according to disktab, etc., is wrong until newfs actually writes a partition. > The frags info is used by fsck(8) to recover alternate superblocks. You > just broke fsck again. See rev.1.9 for previous breakage, PR2537 for > problems related to this breakage, and rev.1.22 for the previous fix. As I already noted, that wasn't a "fix" judging by all the subsequent failure reports. It doesn't do much good for fsck to work if the user can't even install the OS in the first place. rev 1.22 was a pessimisation from a functionality standpoint and a most unwelcome discovery just 4 hours after the release went out. Bah. - Jordan To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message