From owner-freebsd-hackers  Tue Sep 19 21:34:27 1995
Return-Path: owner-hackers
Received: (from root@localhost)
          by freefall.freebsd.org (8.6.12/8.6.6) id VAA15997
          for hackers-outgoing; Tue, 19 Sep 1995 21:34:27 -0700
Received: from phaeton.artisoft.com (phaeton.Artisoft.COM [198.17.250.211])
          by freefall.freebsd.org (8.6.12/8.6.6) with ESMTP id VAA15992
          for <hackers@freebsd.org>; Tue, 19 Sep 1995 21:34:25 -0700
Received: (from terry@localhost) by phaeton.artisoft.com (8.6.11/8.6.9) id VAA12843 for hackers@freebsd.org; Tue, 19 Sep 1995 21:31:49 -0700
From: Terry Lambert <terry@lambert.org>
Message-Id: <199509200431.VAA12843@phaeton.artisoft.com>
Subject: GOTO haters to square one
To: hackers@freebsd.org
Date: Tue, 19 Sep 1995 21:31:49 -0700 (MST)
X-Mailer: ELM [version 2.4 PL24]
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Content-Length: 976       
Sender: owner-hackers@freebsd.org
Precedence: bulk

Has anyone else noticed:

The only code of mine David & Nate have seen from me is kern_lkm.c
(no goto's), init_main.c (no goto's), the associated SYSINIT()
changes to other files, and the additional support for NFS locking
in vfs_syscalls.c + kern_lockf.c + kern_descrip.c (all with no goto's).

I wonder where my supposed overuse of goto's comes from?

I know, it's my use of error_1 and error_2 in my vfs_mountroot()
in vfs_conf.c.

Lessee... the error_2 *is* a bit spurious.  I should have gotten rid
of it when I simplified the code down.  It should be use negative
logic.

The error_1 is probably spurios as well, mostly because the mount
point locking should be implied in VFS_MOUNT() instead of right
after allocation.  Well, what do you know!  An interface layering
problem of the type that I've been talking about fixing!

8-).


					Terry Lambert
					terry@lambert.org
---
Any opinions in this posting are my own and not those of my present
or previous employers.